Skip to content

Adjust selection rects inclusion criteria#125022

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
moffatman:selection_rects_corners
Apr 22, 2023
Merged

Adjust selection rects inclusion criteria#125022
auto-submit[bot] merged 3 commits intoflutter:masterfrom
moffatman:selection_rects_corners

Conversation

@moffatman
Copy link
Contributor

@moffatman moffatman commented Apr 18, 2023

Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.

Part of #30476

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Apr 18, 2023
hellohuanlin
hellohuanlin reviewed Apr 18, 2023
View reviewed changes
LongCatIsLooong
LongCatIsLooong reviewed Apr 19, 2023
View reviewed changes
@moffatman moffatman force-pushed the selection_rects_corners branch 3 times, most recently from 6dbfa84 to 6a430db Compare April 21, 2023 15:34
LongCatIsLooong
LongCatIsLooong approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this!

@moffatman
Adjust selection rects inclusion criteria
bd59e7b 
Include rects with any overlap instead of only when top-left or bottom-right included
@moffatman
Fix criteria
a478496
@moffatman
Reword comment
c85d878
@moffatman moffatman force-pushed the selection_rects_corners branch from 6a430db to c85d878 Compare April 21, 2023 20:57
@moffatman moffatman added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 22, 2023
@auto-submit auto-submit bot merged commit e84daf3 into flutter:master Apr 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
dd9a6d0 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
d20c6d3 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
b7d0035 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
55a93c1 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
207ea55 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
7870014 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
05d5427 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
61c4dc2 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
47e9eb1 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
ef47d05 
…5022)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
5e429b3 
…5022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
ec14d63 
…5022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
3f4e124 
…5022)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023
@engine-flutter-autoroll
e84daf3 Adjust selection rects inclusion criteria (flutter/flutter#12…
ce99c59 
…5022)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlin hellohuanlin hellohuanlin left review comments

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@moffatman @LongCatIsLooong @hellohuanlin