Update xcode to 14c18 for host only bots#125211
Conversation
| dependencies: >- | ||
| [ | ||
| {"dependency": "xcode", "version": "14a5294e"}, | ||
| {"dependency": "xcode", "version": "14c18"}, |
There was a problem hiding this comment.
Instead of setting this at the builder level can we just set it once at the top mac_benchmark?
There was a problem hiding this comment.
Seems Mac_benchmark flutter_tool_startup__macos doesn't need an xcode. I guess it is okay for it to ask for an xcode if we move to the platform level?
There was a problem hiding this comment.
Ah you're right, that one is testing how long the tool itself is taking to update on each host platform.
If we want to coalesce these into platform_properties we can figure that out in a future PR.
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM, thank you so much @keyonghan!
| dependencies: >- | ||
| [ | ||
| {"dependency": "xcode", "version": "14a5294e"}, | ||
| {"dependency": "xcode", "version": "14c18"}, |
There was a problem hiding this comment.
Ah you're right, that one is testing how long the tool itself is taking to update on each host platform.
If we want to coalesce these into platform_properties we can figure that out in a future PR.
keyonghan
added
autosubmit
|
Yeah, removed the |
keyonghan
added
the
autosubmit
|
auto label is removed for flutter/flutter, pr: 125211, due to This PR has not met approval requirements for merging. Changes were requested by {jmagman}, please make the needed changes and resubmit this PR.
|
auto-submit
bot
removed
the
autosubmit
2 participants
With https://flutter-review.googlesource.com/c/recipes/+/42160, we are ready to make all tests consistent with xcode 14c18.