Migrate Xcode projects last version checks to Xcode 14.3 by jmagman · Pull Request #125827 · flutter/flutter

jmagman · 2023-05-01T19:11:40Z

Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent Update to recommended settings warning.
Update iOS and macOS templates to same.
Update iOS template to set BuildIndependentTargetsInParallel to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
Run all example/integration test project to see migrator work.
Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside SHARD=build_tests.

Fixes #125817
See #90304 for Xcode 13 example.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jmagman · 2023-05-01T19:16:28Z

dev/bots/test.dart

+    ..add(Directory(path.join(flutterRoot, 'dev', 'integration_tests', 'ios_app_with_extensions')))
    ..add(Directory(path.join(flutterRoot, 'dev', 'integration_tests', 'non_nullable')))
+    ..add(Directory(path.join(flutterRoot, 'dev', 'integration_tests', 'platform_interaction')))
+    ..add(Directory(path.join(flutterRoot, 'dev', 'integration_tests', 'spell_check')))


Add these integration test projects to build in presubmit.

jmagman · 2023-05-01T19:16:47Z

packages/flutter_tools/lib/src/migrations/xcode_project_object_version_migration.dart

-      // Value has been 0730, 0800, 1020, and 1300 in the template.
-      RegExp(r'LastUpgradeCheck = \d+;'): 'LastUpgradeCheck = 1300;',
+      // Value has been 0730, 0800, 1020, 1300, and 1430 in the template.
+      RegExp(r'LastUpgradeCheck = \d+;'): 'LastUpgradeCheck = 1430;',


This is the migration change.

jmagman · 2023-05-01T19:17:02Z

packages/flutter_tools/templates/app_shared/ios-objc.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 1300;
+				BuildIndependentTargetsInParallel = YES;


Added to iOS template but not migration.

jmagman · 2023-05-01T19:17:37Z

packages/flutter_tools/templates/app_shared/macos.tmpl/Runner.xcodeproj/project.pbxproj.tmpl

 			attributes = {
 				LastSwiftUpdateCheck = 0920;
-				LastUpgradeCheck = 1300;
+				LastUpgradeCheck = 1430;


Not sure if BuildIndependentTargetsInParallel was needed for macOS template, there was no prompt in Xcode to turn it on. Skip it.

vashworth

LGTM

christopherfujino · 2023-05-01T21:21:37Z

dev/integration_tests/spell_check/ios/Runner.xcodeproj/project.pbxproj

 	objects = {

 /* Begin PBXBuildFile section */
+		08DF46C1ECE03723F402A526 /* libPods-Runner.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 49B50C6BD3C1A11B60BCFF13 /* libPods-Runner.a */; };


should I be reviewing this?

It looks like spell_check wasn't checked in after being built? Anyway I built it and CocoaPods and Xcode wanted this.

christopherfujino

LGTM

cyanglaz

LGTM

…tter/flutter#125827)

flutter/flutter@828a040...db6074a 2023-05-02 [email protected] Roll Flutter Engine from 46d5ce4784b8 to 44376e8cd3de (1 revision) (flutter/flutter#125876) 2023-05-02 [email protected] Roll Flutter Engine from a687d62ff631 to 46d5ce4784b8 (1 revision) (flutter/flutter#125874) 2023-05-02 [email protected] Roll Flutter Engine from d0ed35b7bf67 to a687d62ff631 (1 revision) (flutter/flutter#125871) 2023-05-02 [email protected] Roll Flutter Engine from c0d68c36c376 to d0ed35b7bf67 (1 revision) (flutter/flutter#125870) 2023-05-02 [email protected] Roll Flutter Engine from a9e38dd0510d to c0d68c36c376 (1 revision) (flutter/flutter#125868) 2023-05-02 [email protected] Roll Flutter Engine from 024bf946232d to a9e38dd0510d (2 revisions) (flutter/flutter#125866) 2023-05-02 [email protected] Make `future` and `stream` required arguments in their respective builder widgets (flutter/flutter#125838) 2023-05-02 [email protected] Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (flutter/flutter#125858) 2023-05-02 [email protected] Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (flutter/flutter#125845) 2023-05-02 [email protected] Migrate Xcode projects last version checks to Xcode 14.3 (flutter/flutter#125827) 2023-05-01 [email protected] Roll Flutter Engine from 58cc54197a54 to 3fa6084dfb36 (1 revision) (flutter/flutter#125839) 2023-05-01 [email protected] Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (flutter/flutter#125833) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…tter/flutter#125827)

Migrate Xcode projects last version checks to Xcode 14.3

50bf520

jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. platform-mac Building on or for macOS specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels May 1, 2023

jmagman self-assigned this May 1, 2023

jmagman commented May 1, 2023

View reviewed changes

jmagman marked this pull request as ready for review May 1, 2023 19:42

jmagman requested review from christopherfujino, cyanglaz and vashworth May 1, 2023 19:42

vashworth approved these changes May 1, 2023

View reviewed changes

christopherfujino reviewed May 1, 2023

View reviewed changes

christopherfujino approved these changes May 1, 2023

View reviewed changes

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2023

cyanglaz approved these changes May 1, 2023

View reviewed changes

auto-submit bot merged commit 1861ac4 into flutter:master May 2, 2023

engine-flutter-autoroll mentioned this pull request May 2, 2023

Roll Flutter from 828a04040e11 to db6074ade4e4 (12 revisions) flutter/packages#3881

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2023

1861ac4 Migrate Xcode projects last version checks to Xcode 14.3 (flu…

cc2d07a

…tter/flutter#125827)

jmagman deleted the ios-project-recommend branch May 2, 2023 17:54

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

1861ac4 Migrate Xcode projects last version checks to Xcode 14.3 (flu…

da7faaf

…tter/flutter#125827)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

1861ac4 Migrate Xcode projects last version checks to Xcode 14.3 (flu…

19f6d0b

…tter/flutter#125827)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

1861ac4 Migrate Xcode projects last version checks to Xcode 14.3 (flu…

503a451

…tter/flutter#125827)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

1861ac4 Migrate Xcode projects last version checks to Xcode 14.3 (flu…

6a2b97b

…tter/flutter#125827)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Xcode projects last version checks to Xcode 14.3#125827

Migrate Xcode projects last version checks to Xcode 14.3#125827
auto-submit[bot] merged 1 commit intoflutter:masterfrom
jmagman:ios-project-recommend

jmagman commented May 1, 2023 •

edited

Loading

Uh oh!

jmagman May 1, 2023

Uh oh!

jmagman May 1, 2023

Uh oh!

jmagman May 1, 2023

Uh oh!

jmagman May 1, 2023

Uh oh!

vashworth left a comment

Uh oh!

christopherfujino May 1, 2023

Uh oh!

jmagman May 1, 2023

Uh oh!

christopherfujino May 1, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

cyanglaz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jmagman commented May 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

jmagman May 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman May 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman May 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman May 1, 2023

Choose a reason for hiding this comment

Uh oh!

vashworth left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino May 1, 2023

Choose a reason for hiding this comment

Uh oh!

jmagman May 1, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino May 1, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

cyanglaz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmagman commented May 1, 2023 •

edited

Loading