Adds vmservices to retrieve android applink settings#125998
Adds vmservices to retrieve android applink settings#125998auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
the
tool
chunhtai
force-pushed
the
issues/120408-applink
branch
5 times, most recently
from
8c30d81 to
bd14573
Compare
There was a problem hiding this comment.
I need this check to avoid crash when running gradle in flutter modules that are use in add to app scenario
There was a problem hiding this comment.
I think this is because you are depending on steps that only exist for apps. But I would expect add to app to work and potentially problems with libraries.
Does this need to be cherry picked into either beta or stable?
There was a problem hiding this comment.
for add to app, these tasks can only be added in the main android project.
I think in the future I should refactor this out into a separate gradle plugin to support add-to-app, but I would like to make the decision later when we have more concrete design for add-to-app support in deeplink validation tool.
This doesn't need to be cherry pick as there isn't a client using these tasks yet.
|
Hi, @chunhtai is this still a work in progress? Seems like you have some tests failing |
chunhtai
force-pushed
the
issues/120408-applink
branch
2 times, most recently
from
ecb584f to
27f5f46
Compare
|
These tests failures seem to be related to #126557 |
chunhtai
force-pushed
the
issues/120408-applink
branch
from
e16b622 to
fff1c6c
Compare
There was a problem hiding this comment.
I think this is because you are depending on steps that only exist for apps. But I would expect add to app to work and potentially problems with libraries.
Does this need to be cherry picked into either beta or stable?
chunhtai
force-pushed
the
issues/120408-applink
branch
from
fff1c6c to
19feb3e
Compare
There was a problem hiding this comment.
I think according to https://developer.android.com/reference/tools/gradle-api/7.4/com/android/build/api/variant/ApplicationVariant#applicationId() this depends on some task running that will merge the manifests. That means this task depends on another task (possibly as simple as assembleVariant). Given this I think you should add a dependsOn block as defined here. https://docs.gradle.org/current/userguide/tutorial_using_tasks.html#sec:task_dependencies
There was a problem hiding this comment.
I think you might actually want variant.outputs.each see example here https://developer.android.com/build/gradle-tips#configure-dynamic-version-codes to print the applicationId.
But I am not sure how task registration interacts differently if you use outputs.
There was a problem hiding this comment.
FWIW I am trying to give good guidance here if you explore these things and they dont work you can ignore my comments.
There was a problem hiding this comment.
It looks like it is not depending on any task, I ran it after a clean, and it still works. Also the application id is per applicationvariant I think? i didn't see a property on variantoutput for applicationID.
chunhtai
force-pushed
the
issues/120408-applink
branch
from
19feb3e to
dd4c8a7
Compare
chunhtai
added
the
autosubmit
flutter/flutter@8a5c22e...6e254a3 2023-06-08 [email protected] [labeler] Set sync labels to false to stop removing labels (flutter/flutter#128446) 2023-06-08 [email protected] Update Chrome version for testing (flutter/flutter#128447) 2023-06-08 [email protected] Revert "Redo make inspector weakly referencing the inspected objects." (flutter/flutter#128506) 2023-06-08 [email protected] Use `--target-os` for appropriate precompiled targets. (flutter/flutter#127567) 2023-06-08 [email protected] Redo make inspector weakly referencing the inspected objects. (flutter/flutter#128471) 2023-06-07 [email protected] Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) (flutter/flutter#128473) 2023-06-07 [email protected] Disable context menu (flutter/flutter#128365) 2023-06-07 [email protected] Adds vmservices to retrieve android applink settings (flutter/flutter#125998) 2023-06-07 [email protected] Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (flutter/flutter#128460) 2023-06-07 [email protected] Fix typos 'wether' -> 'whether' (flutter/flutter#128392) 2023-06-07 [email protected] Roll engine, patch expression evaluation (flutter/flutter#128255) 2023-06-07 [email protected] Roll Packages from da72219 to a84b2c2 (1 revision) (flutter/flutter#128444) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
fixes #120408
Added two gradle tasks, one for grabing the application id, one for grabbing app link domains.
Added a new vmservices to call these two gradle tasks and return the result.
The expected work flow is that the devtool will first call a vmservices to grab all avaliable build variants. It will then choose one of the build variant and call this new services to get application id and app link domains.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.