Skip to content

Upgrade leak_tracker to 5.0.0#126367

Merged
auto-submit[bot] merged 10 commits intoflutter:masterfrom
polina-c:version
May 16, 2023
Merged

Upgrade leak_tracker to 5.0.0#126367
auto-submit[bot] merged 10 commits intoflutter:masterfrom
polina-c:version

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented May 9, 2023 •
edited
Loading

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 9, 2023
@github-actions github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: integration_test The flutter/packages/integration_test plugin labels May 9, 2023
christopherfujino
christopherfujino approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino mentioned this pull request May 9, 2023
Closed
goderbauer
goderbauer approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented May 10, 2023

Looks like the checks are unhappy, though.

@christopherfujino
Copy link
Contributor

christopherfujino commented May 10, 2023

So this is breaking analysis because package:vm_service added package:protobuf and package:fixnum to the transitive closure in dart-lang/sdk@6c3c345#diff-e8b526145c30754d3e9fe773ac388cb9c9c30a4210628dae2f534eee7ef6c63f

@polina-c
Copy link
Contributor Author

polina-c commented May 11, 2023

cc @derekxu16

@christopherfujino
Copy link
Contributor

christopherfujino commented May 12, 2023

I will push a change to this PR pinning package:vm_service.

@christopherfujino
Copy link
Contributor

christopherfujino commented May 12, 2023

Ok, the version of vm_service introducing protobuf was retracted, so I rolled back that dep in d049ebc, let's see if CI passes.

@christopherfujino
Copy link
Contributor

christopherfujino commented May 12, 2023

Looks I might have pulled in a new dep that has another build failure:

[        ] A problem occurred evaluating project ':camera_android'.
[        ] > Could not set unknown property 'baseline' for task ':camera_android:lint' of type com.android.build.gradle.tasks.LintGlobalTask.
[        ] * Try:
[        ] > Run with --debug option to get more log output.
[        ] > Run with --scan to get full insights.
[        ] * Exception is:
[        ] org.gradle.api.GradleScriptException: A problem occurred evaluating project ':camera_android'.

@Renzo-Olivares Renzo-Olivares mentioned this pull request May 12, 2023
Closed
@christopherfujino christopherfujino mentioned this pull request May 12, 2023
Closed
@github-actions github-actions bot added the a: internationalization Supporting other languages or locales. (aka i18n) label May 12, 2023
@christopherfujino
Copy link
Contributor

christopherfujino commented May 12, 2023

pinned camera_android per #126710

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
8cb5142
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
a76731e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
c2e7b62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
0eefcf9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
19e89ce
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
ca6364e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
fad57f8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
01f997a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
66ac2d1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
2559eb7
@polina-c polina-c deleted the version branch May 17, 2023 03:34
@polina-c polina-c mentioned this pull request May 17, 2023
Closed
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@polina-c
Upgrade leak_tracker to 5.0.0 (flutter#126367)
bd122d1 
Fixes flutter#126259

Updated pubspec:
https://github.com/flutter/flutter/blob/345f0bffbfda31fab7d4a740f65b3d1610d20a99/packages/flutter/pubspec.yaml
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
8d92699
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
2d3dd06
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
8458ecb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
ea5eddb Upgrade leak_tracker to 5.0.0 (flutter/flutter#126367)
df81b85
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leak Tracking is flaky

3 participants

@polina-c @goderbauer @christopherfujino