Add FocusNode, onFocusChange, and autofocus to CupertinoSwitch#126684
Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom May 12, 2023
TahaTesser:cupertino_switch_focus_node
Merged
Add FocusNode, onFocusChange, and autofocus to CupertinoSwitch#126684auto-submit[bot] merged 1 commit intoflutter:masterfrom TahaTesser:cupertino_switch_focus_node
FocusNode, onFocusChange, and autofocus to CupertinoSwitch#126684auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:cupertino_switch_focus_node
Conversation
flutter-dashboard
bot
added
f: cupertino
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
May 12, 2023
…to Cupertino variant of `Switch.adaptive` (#126688) fixes #126637 fixes #126669 ## ~~To be merged after #126684 ### Description 1. Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus. 2. Fix `thumbColor` & `focusColor` aren't applied. ### Before Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied. https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a ### After Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied. https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 13, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 16, 2023
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
flutter#126684) fixes flutter#126679 ### Description Control cupertino widgets like `CupertinoCheckbox` and `CupertinoRadio` have `focusNode` and `autofocus`, while these are missing in `CupertinoSwitch`. This is blocking flutter#126637 (`switch.dart` currently maintains its focus node for `CupertinoSwitch` when using `Switch.adaptive` which causes a bug)
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…to Cupertino variant of `Switch.adaptive` (flutter#126688) fixes flutter#126637 fixes flutter#126669 ## ~~To be merged after flutter#126684 ### Description 1. Fix the Cupertino variant of `Switch.adaptive` requires two tab key presses to focus. 2. Fix `thumbColor` & `focusColor` aren't applied. ### Before Requires two tab presses to focus. and `thumbColor` & `focusColor` aren't applied. https://github.com/flutter/flutter/assets/48603081/24635551-0794-443f-8320-32fdaa5de57a ### After Single tab key to focus (no additional focus node) and `thumbColor` & `focusColor` are applied. https://github.com/flutter/flutter/assets/48603081/9bf42fd8-c7e0-475a-b933-192a94650b0c
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #126679
Description
Control cupertino widgets like
CupertinoCheckboxandCupertinoRadiohavefocusNodeandautofocus, while these are missing inCupertinoSwitch.This is blocking #126637
(
switch.dartcurrently maintains its focus node forCupertinoSwitchwhen usingSwitch.adaptivewhich causes a bug)Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.