[flutter_tools] delete entitlements files after copying to macos build dir#126875
Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom May 22, 2023
Merged
Conversation
flutter-dashboard
bot
added
the
tool
auto-submit bot
pushed a commit
to flutter/cocoon
that referenced
this pull request
May 16, 2023
Remove codesign metadata after parsing them. Context: fix flutter/flutter#126705 by removing codesign metadata after parsing them. When flutter/flutter#126875 becomes ready, we could add back codesign metadata inside engine zips? Sorry for the delay, was busy landing different cps during the day
christopherfujino
force-pushed
the
delete-entitlements-files
branch
from
f95e60c to
9787320
Compare
Contributor
|
Are the entitlement files not needed anymore once they reach the tool? I haven't seen a purpose for them but could be something I'm unaware of. Asking because seems like your code will remove all entitlement files and not just the one inside the FlutterMacOS.framework |
Contributor
Author
Yes, the only purpose for them is as an input to the codesign tool which runs as part of the engine builds that generate and upload artifacts. @XilaiZhang just made a change to have that tool delete them after use (0fc0cd5)--however I figured we should be safe and delete them on the tool side, as I'm not sure if we codesign on the main channel of the engine. |
XilaiZhang
approved these changes
May 19, 2023
Contributor
XilaiZhang
left a comment
XilaiZhang
left a comment
There was a problem hiding this comment.
The is! operator is very cool. today i learnt.
Yeah if we remove the codesign metadata from the tools logic, we might be able to add it back in the initial engine zips so people could reference it when they add new binaries.
christopherfujino
added
the
autosubmit
christopherfujino
added a commit
to chris-forks/flutter
that referenced
this pull request
May 22, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 23, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 23, 2023
flutter/flutter@3437189...f86c529 2023-05-23 [email protected] Roll Flutter Engine from 431ed51c6415 to 168b0bf3f70d (1 revision) (flutter/flutter#127382) 2023-05-23 [email protected] Roll Flutter Engine from cc79ae858591 to 431ed51c6415 (1 revision) (flutter/flutter#127381) 2023-05-23 [email protected] Roll Flutter Engine from 311438399a45 to cc79ae858591 (1 revision) (flutter/flutter#127377) 2023-05-23 [email protected] Roll Flutter Engine from c284cd10e7ab to 311438399a45 (1 revision) (flutter/flutter#127376) 2023-05-23 [email protected] Roll Flutter Engine from 8d6602b030be to c284cd10e7ab (2 revisions) (flutter/flutter#127372) 2023-05-23 [email protected] Add M3 date picker tests and fix divider (flutter/flutter#127197) 2023-05-23 [email protected] Roll Flutter Engine from 2586cbeeae37 to 8d6602b030be (2 revisions) (flutter/flutter#127370) 2023-05-23 [email protected] Manual roll Flutter Engine from a342a9186e69 to 2586cbeeae37 (14 revisions) (flutter/flutter#127369) 2023-05-23 [email protected] [Android] Adds `namespace` to module build file templates (flutter/flutter#126963) 2023-05-23 [email protected] Revert Engine to a342a9186e69 (flutter/flutter#127368) 2023-05-23 [email protected] Roll Flutter Engine from 2a325eed77d0 to 41e8d52a006a (2 revisions) (flutter/flutter#127365) 2023-05-23 [email protected] Roll Flutter Engine from a342a9186e69 to 2a325eed77d0 (7 revisions) (flutter/flutter#127364) 2023-05-23 [email protected] Remove null-safety argument from DartPad doc samples (flutter/flutter#127345) 2023-05-22 [email protected] Support keeping a bottom sheet with a DraggableScrollableSheet from closing on drag/fling to min extent (flutter/flutter#127339) 2023-05-22 [email protected] Fix wasm-opt location when using local_web_sdk (flutter/flutter#127355) 2023-05-22 [email protected] Roll Flutter Engine from 1ed9fc0caf55 to a342a9186e69 (3 revisions) (flutter/flutter#127352) 2023-05-22 [email protected] Show warning when attempting to flutter run on an ios device with developer mode turned off (flutter/flutter#125710) 2023-05-22 [email protected] Suggest that people move to "beta" when they upgrade on "master" (flutter/flutter#127146) 2023-05-22 [email protected] add test for setting JAVA_HOME and PATH when invoking `sdkmanager --licenses` (flutter/flutter#127344) 2023-05-22 [email protected] Roll Flutter Engine from e04c14786d5a to 1ed9fc0caf55 (1 revision) (flutter/flutter#127343) 2023-05-22 [email protected] fix: Search anchor box location when used on nested navigator (flutter/flutter#127198) 2023-05-22 [email protected] [flutter_tools] delete entitlements files after copying to macos build dir (flutter/flutter#126875) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
christopherfujino
added a commit
to chris-forks/flutter
that referenced
this pull request
May 23, 2023
…d dir (flutter#127417) Fixes flutter#126705 Follow up fix after flutter#126875 did NOT work.
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…d dir (flutter#127417) Fixes flutter#126705 Follow up fix after flutter#126875 did NOT work.
8 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126705