Skip to content

Log all lines from ios-deploy#127502

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
vashworth:dart_vm_timeout_debug_v3
May 24, 2023
Merged

Log all lines from ios-deploy#127502
auto-submit[bot] merged 2 commits intoflutter:masterfrom
vashworth:dart_vm_timeout_debug_v3

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented May 24, 2023 •
edited
Loading

Reland #127222 that was reverted in #127405.

Fixed Mac_ios microbenchmarks_ios test failure by not echoing logs twice.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels May 24, 2023
@github-actions github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label May 24, 2023
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 24, 2023
@vashworth vashworth marked this pull request as ready for review May 24, 2023 17:06
christopherfujino
christopherfujino approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2023
@auto-submit auto-submit bot merged commit a19b343 into flutter:master May 24, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
8aaf7f2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
344a213
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
1f0d068
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
d09e342
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
685dd13
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
ce4b08f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
ed954b4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
dfa745d
@reidbaker reidbaker mentioned this pull request May 25, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
1ad08ec
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 26, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
0923285
vashworth added a commit to vashworth/flutter that referenced this pull request May 26, 2023
@vashworth
Revert "Log all lines from ios-deploy (flutter#127502)"
cb53e76 
This reverts commit a19b343.
@reidbaker reidbaker mentioned this pull request May 26, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request May 26, 2023
@vashworth
Revert "Log all lines from ios-deploy (#127502)" (#127684)
8e6a9e3 
This reverts commit a19b343.

We added this logging to try and determine if the reason for Dart VM errors (#121231) was caused by some issue with the streams.
A recent test proves that is not the case:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_ios%20platform_view_ios__start_up/11046/overview
The test shows the Dart VM url in the device log. However, the test log does NOT show a log for the Dart VM url but does show the stack trace, which all come from the main stream, which means it's not an issue with the secondary streams not receiving the log.

So reverting the debugging we added.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
e8ac2e5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
7313c61
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
ad52010
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
a19b343 Log all lines from ios-deploy (flutter/flutter#127502)
8235efc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @christopherfujino