CP: [Linux] Ignore deprecation of libupower call in example (#127503)#127528
Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.10-candidate.1from May 26, 2023
godofredoc:flutter-3.10-candidate.1
Merged
CP: [Linux] Ignore deprecation of libupower call in example (#127503)#127528auto-submit[bot] merged 1 commit intoflutter:flutter-3.10-candidate.1from godofredoc:flutter-3.10-candidate.1
auto-submit[bot] merged 1 commit intoflutter:flutter-3.10-candidate.1from
godofredoc:flutter-3.10-candidate.1
Conversation
The Linux platform channels sample makes a call to the libupower function `up_client_get_devices`, which was deprecated in libupower 0.99.8 in favour of `up_client_get_devices2`. The prod bots have been migrated to focal, which ships libupower 0.99.11 in which the old function is deprecated and the new one is available. The try bots have not yet been migrated and remain on bionic, which ships libupower 0.99.7 in which the old function is not deprecated and the new one is not available. This marks the line in question to ignore deprecation warnings. Once all bots have migrated to focal, we'll migrate to the new function. See tracking issue below. See: https://upower.freedesktop.org/docs/UpClient.html#up-client-get-devices Issue: #127506 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
flutter-dashboard
bot
added
d: examples
fluttergithubbot
approved these changes
May 24, 2023
cbracken
approved these changes
May 26, 2023
CaseyHillers
added
the
autosubmit
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CP: edf4a91
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Contributor Guide:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview Tree Hygiene: https://github.com/flutter/flutter/wiki/Tree-hygiene test-exempt:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests Flutter Style Guide:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo Features we expect every widget to implement:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement CLA: https://cla.developers.google.com/
flutter/tests: https://github.com/flutter/tests
breaking change policy:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes Discord: https://github.com/flutter/flutter/wiki/Chat
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.