Disable blinking cursor when `EditableText.showCursor` is false by LongCatIsLooong · Pull Request #127562 · flutter/flutter

LongCatIsLooong · 2023-05-25T08:38:50Z

Fixes #108187

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM 👍, this is will probably save a lot of unnecessary CPU in the world.

packages/flutter/test/widgets/selectable_text_test.dart

justinmc

Renewing my LGTM with the changes 👍

justinmc · 2023-06-06T22:01:58Z

packages/flutter/test/widgets/editable_text_cursor_test.dart

Nit: Extra space before the period here. Or maybe that's fine to distinguish the URL...

Yeah when I click the URL in vscode I think it would bring me to a nonexistent page if the space is removed. It's valid in URLs I think.

Well I forgot to update the name of the test. Removed the space and updated the test name.

auto-submit · 2023-06-06T22:29:41Z

auto label is removed for flutter/flutter, pr: 127562, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

chunhtai

LGTM, just some nits

chunhtai · 2023-06-06T22:34:06Z

packages/flutter/lib/src/widgets/editable_text.dart

Consider moving this into a getter also why not move _tickersEnabled into this bool like the one below does

auto-submit · 2023-06-07T08:27:30Z

auto label is removed for flutter/flutter, pr: 127562, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-06-08T06:35:05Z

auto label is removed for flutter/flutter, pr: 127562, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…se (flutter/flutter#127562)

flutter/flutter@6e254a3...da127f1 2023-06-09 [email protected] Updated material button theme tests for Material3 (flutter/flutter#128543) 2023-06-09 [email protected] Roll Flutter Engine from cb93477008d6 to 93afba901b3b (2 revisions) (flutter/flutter#128573) 2023-06-09 [email protected] Improve defaults generation with logging, stats, and token validation (flutter/flutter#128244) 2023-06-09 [email protected] [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (flutter/flutter#128335) 2023-06-09 [email protected] [flutter_tools] [DAP] Don't try to restart/reload if app hasn't started yet (flutter/flutter#128267) 2023-06-09 [email protected] Roll Flutter Engine from 8f9e608d39ab to cb93477008d6 (3 revisions) (flutter/flutter#128568) 2023-06-09 [email protected] Replace `MaterialButton` from test classes (flutter/flutter#128466) 2023-06-09 [email protected] Fix `showBottomSheet` doesn't remove scrim when draggable sheet is dismissed (flutter/flutter#128455) 2023-06-09 [email protected] Manual roll Flutter Engine from a5f7d5d75ff2 to 8f9e608d39ab (31 revisions) (flutter/flutter#128554) 2023-06-09 [email protected] Revert "test owners: cyanglaz -> vashworth" (flutter/flutter#128462) 2023-06-09 [email protected] [Android] Bump integration tests using `compileSdkVersion` 31 to 33 (flutter/flutter#128072) 2023-06-09 [email protected] Remove single view assumption from MouseTracker, and unify its hit testing code flow (flutter/flutter#127060) 2023-06-09 [email protected] [flutter_tools] Precache after channel switch (flutter/flutter#118129) 2023-06-08 [email protected] Adding migration guide for Material 3 colors (flutter/flutter#128429) 2023-06-08 [email protected] Add `AppLifecycleListener`, with support for application exit handling (flutter/flutter#123274) 2023-06-08 [email protected] Sliver Main Axis Group (flutter/flutter#126596) 2023-06-08 [email protected] Reduce `_DoubleClampVisitor` false positives (flutter/flutter#128539) 2023-06-08 [email protected] Advise developers to use OverflowBar instead of ButtonBar (flutter/flutter#128437) 2023-06-08 [email protected] Reland "Migrate benchmarks to package:web" (flutter/flutter#128266) 2023-06-08 [email protected] Navigator.pop before PopupMenuItem onTap call (flutter/flutter#127446) 2023-06-08 [email protected] Fix navigation rail with long labels misplaced highlights (flutter/flutter#128324) 2023-06-08 [email protected] Update `chip.dart` to use set of `MaterialState` (flutter/flutter#128507) 2023-06-08 [email protected] Update flutter to dartdoc 6.3.0 and hide Icons implementation from doc pages (flutter/flutter#128442) 2023-06-08 [email protected] Disable blinking cursor when `EditableText.showCursor` is false (flutter/flutter#127562) 2023-06-08 [email protected] [floating_cursor_selection]add more comments on the tricky part (flutter/flutter#127227) 2023-06-08 [email protected] Move RenderObjectElement.updateChildren to Element (flutter/flutter#128458) 2023-06-08 [email protected] Fix PointerEventConverter doc (flutter/flutter#128452) 2023-06-08 [email protected] Roll Packages from a84b2c2 to e13b8c4 (9 revisions) (flutter/flutter#128508) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…se (flutter/flutter#127562)

LongCatIsLooong requested a review from justinmc May 25, 2023 08:38

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2023

github-actions bot removed framework flutter/packages/flutter repository. See also f: labels. a: text input Entering text in a text field or keyboard related problems labels May 25, 2023

justinmc approved these changes May 25, 2023

View reviewed changes

LongCatIsLooong commented May 26, 2023

View reviewed changes

packages/flutter/test/widgets/selectable_text_test.dart Outdated Show resolved Hide resolved

goderbauer added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Jun 1, 2023

LongCatIsLooong changed the title ~~Disable blinking cursor for readonly EditableText~~ Disable blinking cursor EditableText.showCursor is false Jun 5, 2023

LongCatIsLooong changed the title ~~Disable blinking cursor EditableText.showCursor is false~~ Disable blinking cursor when EditableText.showCursor is false Jun 5, 2023

LongCatIsLooong requested a review from justinmc June 5, 2023 20:47

justinmc approved these changes Jun 6, 2023

View reviewed changes

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 6, 2023

chunhtai approved these changes Jun 6, 2023

View reviewed changes

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023

LongCatIsLooong force-pushed the disable-cursor-when-readOnly branch from a54d98c to 573ce91 Compare June 7, 2023 09:13

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023

Squash commits

84d1c6c

LongCatIsLooong force-pushed the disable-cursor-when-readOnly branch from fcb1a14 to 84d1c6c Compare June 8, 2023 18:49

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023

auto-submit bot merged commit 37f20c2 into flutter:master Jun 8, 2023

LongCatIsLooong deleted the disable-cursor-when-readOnly branch June 8, 2023 21:42

engine-flutter-autoroll mentioned this pull request Jun 9, 2023

Roll Flutter from 6e254a3f9fb7 to da127f15ad54 (28 revisions) flutter/packages#4170

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2023

37f20c2 Disable blinking cursor when EditableText.showCursor is fal…

e89c40c

…se (flutter/flutter#127562)

HansMuller mentioned this pull request Jun 9, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

37f20c2 Disable blinking cursor when EditableText.showCursor is fal…

d7a696b

…se (flutter/flutter#127562)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

37f20c2 Disable blinking cursor when EditableText.showCursor is fal…

f002b69

…se (flutter/flutter#127562)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

37f20c2 Disable blinking cursor when EditableText.showCursor is fal…

533b425

…se (flutter/flutter#127562)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023

37f20c2 Disable blinking cursor when EditableText.showCursor is fal…

1ce4f66

…se (flutter/flutter#127562)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable blinking cursor when `EditableText.showCursor` is false#127562

Disable blinking cursor when `EditableText.showCursor` is false#127562
auto-submit[bot] merged 1 commit intoflutter:masterfrom
LongCatIsLooong:disable-cursor-when-readOnly

LongCatIsLooong commented May 25, 2023

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

justinmc left a comment

Uh oh!

justinmc Jun 6, 2023

Uh oh!

LongCatIsLooong Jun 6, 2023

Uh oh!

LongCatIsLooong Jun 6, 2023

Uh oh!

auto-submit bot commented Jun 6, 2023

Uh oh!

chunhtai left a comment

Uh oh!

chunhtai Jun 6, 2023

Uh oh!

auto-submit bot commented Jun 7, 2023

Uh oh!

auto-submit bot commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LongCatIsLooong commented May 25, 2023

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 6, 2023

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

chunhtai Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 7, 2023

Uh oh!

auto-submit bot commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants