Skip to content

Avoid catching FlutterError in TextPainter tests#127604

Merged
tgucio merged 2 commits intoflutter:masterfrom
tgucio:dont-catch-errors
May 30, 2023
Merged

Avoid catching FlutterError in TextPainter tests#127604
tgucio merged 2 commits intoflutter:masterfrom
tgucio:dont-catch-errors

Conversation

@tgucio
Copy link
Contributor

@tgucio tgucio commented May 25, 2023

This PR swaps catching FlutterError with expect in TextPainter tests (missed in #127307).

test-exempt: no functional change (only test code changed)

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2023
@github-actions github-actions bot removed a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels May 25, 2023
@tgucio tgucio added the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 25, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented May 25, 2023

auto label is removed for flutter/flutter, pr: 127604, due to This PR has not met approval requirements for merging. You are a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@tgucio tgucio requested a review from LongCatIsLooong May 30, 2023 16:51
@github-actions github-actions bot added the a: text input Entering text in a text field or keyboard related problems label May 30, 2023
@tgucio tgucio merged commit 1b5899a into flutter:master May 30, 2023
@tgucio tgucio deleted the dont-catch-errors branch May 30, 2023 17:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
1b5899a Avoid catching FlutterError in TextPainter tests (flutter/flu…
c503143 
…tter#127604)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
1b5899a Avoid catching FlutterError in TextPainter tests (flutter/flu…
6323f06 
…tter#127604)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1b5899a Avoid catching FlutterError in TextPainter tests (flutter/flu…
c009ce1 
…tter#127604)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1b5899a Avoid catching FlutterError in TextPainter tests (flutter/flu…
eda5484 
…tter#127604)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1b5899a Avoid catching FlutterError in TextPainter tests (flutter/flu…
af83654 
…tter#127604)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tgucio @LongCatIsLooong