ContextAction.isEnabled needs a context#127721
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Jun 14, 2023
Merged
ContextAction.isEnabled needs a context#127721auto-submit[bot] merged 2 commits intoflutter:masterfrom
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
flutter-dashboard
bot
added
f: scrolling
github-actions
bot
removed
framework
Contributor
There was a problem hiding this comment.
Suggested change
| /// This finds the nearest _ancestor_ [Scrollable] if the `context`. This | |
| /// This finds the nearest _ancestor_ [Scrollable] of the `context`. This |
Contributor
There was a problem hiding this comment.
This design feels clunky. Perhaps it should just always return true from isEnabled, and instead do the search for the enabled action in invoke, doing nothing if nothing is enabled. Then at least the search for the first enabled action is happening coupled with the invocation.
That doesn't help with showing some kind of enabled feedback in the UI though.
Maybe something along the lines of your invokeActionIfEnabled would work better here, to combine the two steps. Oh, but you still have to implement the rest of the Action API, I guess. Ugh.
Not sure what the right answer is, but it feels clunky.
Contributor
Author
There was a problem hiding this comment.
I don't disagree but this PR doesn't affect any of that, I'm just documenting reality here.
Contributor
There was a problem hiding this comment.
Suggested change
| /// This finds the nearest _ancestor_ [Scrollable] if the `context`. This | |
| /// This finds the nearest _ancestor_ [Scrollable] of the `context`. This |
Contributor
There was a problem hiding this comment.
Oooh, Dart 3 API. Nice.
Contributor
Author
There was a problem hiding this comment.
yeah i struggled with how to implement this for ages until i realised the answer was just to return... both pieces of information :-)
Contributor
Author
|
Fixed the docs error. |
goderbauer
added
framework
Contributor
Author
|
Web failures are caused by dart-lang/sdk#52593. |
...and lots of things that fall out from that
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 15, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 15, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 15, 2023
flutter/flutter@95be76a...b0188cd 2023-06-15 [email protected] [web] Pass creation params to the platform view factory (flutter/flutter#128146) 2023-06-15 [email protected] [flutter_tools] cache flutter sdk version to disk (flutter/flutter#124558) 2023-06-14 [email protected] Fix inconsistently suffixed macOS flavored bundle directory (flutter/flutter#127997) 2023-06-14 [email protected] Update golden tests for material (flutter/flutter#128839) 2023-06-14 [email protected] Update getChildrenSummaryTree to handle Diagnosticable as input. (flutter/flutter#128833) 2023-06-14 [email protected] Improve the error message for non-normalized constraints (flutter/flutter#127906) 2023-06-14 [email protected] ContextAction.isEnabled needs a context (flutter/flutter#127721) 2023-06-14 [email protected] Remove temporary default case for PointerSignalKind (flutter/flutter#128900) 2023-06-14 [email protected] Respect allowlisted count of leaks. (flutter/flutter#128823) 2023-06-14 [email protected] Unpin flutter_plugin_android_lifecycle (flutter/flutter#128898) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and lots of things that fall out from that