Update android manifests to set exported:true on main activities in integration test for api 33 support#127892
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom May 30, 2023
reidbaker:i127682-update-manifests-for-api-33
Merged
Update android manifests to set exported:true on main activities in integration test for api 33 support#127892auto-submit[bot] merged 2 commits intoflutter:masterfrom reidbaker:i127682-update-manifests-for-api-33
auto-submit[bot] merged 2 commits intoflutter:masterfrom
reidbaker:i127682-update-manifests-for-api-33
Conversation
…ntegration test for api 33 support
flutter-dashboard
bot
added
a: accessibility
zanderso
approved these changes
May 30, 2023
Member
zanderso
left a comment
zanderso
left a comment
There was a problem hiding this comment.
lgtm
I missing a bunch of context, but If this flag is backwards compatible, would it make sense to eagerly set it everywhere instead of only in the tests that have failed so far?
github-actions
bot
removed
a: accessibility
Contributor
Author
I believe that is what I did. All the other android manifest files either didnt have an activity or were already exported.
If you think I missed something let me know. |
Contributor
|
This got updated in the template at some point but no one went back through all the androidManifest files in the repo to add it. |
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 3, 2023
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2023
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…ies in integration test for api 33 support (flutter/flutter#127892)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
…ies in integration test for api 33 support (flutter/flutter#127892)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update android manifests to set exported:true on main activities in integration test for api 33 support
#127689
#127884 is resolved by https://flutter-review.googlesource.com/c/recipes/+/45181 but this pr is required to reland.
Pre-launch Checklist
///).