Skip to content

[CP] Stable AGP 8.0 minification support when using integration_test package#127963

Merged
auto-submit[bot] merged 2 commits intoflutter:flutter-3.10-candidate.1from
reidbaker:i127388-stable-cp
Jun 12, 2023
Merged

[CP] Stable AGP 8.0 minification support when using integration_test package#127963
auto-submit[bot] merged 2 commits intoflutter:flutter-3.10-candidate.1from
reidbaker:i127388-stable-cp

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 31, 2023 •
edited
Loading

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker
Support minifcation for apps that depend on AGP 8 and integration_test (
44b884e 
#127628)

- Set exported proguard rules for consumers of integration_test using AGP 8.0
- Updated proguard usage in example to test setting custom proguard rules works.

Documentation for how consumerProguardFiles works. https://developer.android.com/studio/projects/android-library#Considerations

Unknown why we had to use ** instead of matching exactly.
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: text input Entering text in a text field or keyboard related problems d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. f: integration_test The flutter/packages/integration_test plugin c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
@reidbaker reidbaker mentioned this pull request May 31, 2023
Closed
@github-actions github-actions bot removed tool Affects the "flutter" command-line tool. See also t: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels May 31, 2023
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 31, 2023
@reidbaker reidbaker changed the title [CP] AGP 8.0 minification support when using integration_test package [CP] Stable AGP 8.0 minification support when using integration_test package May 31, 2023
@reidbaker reidbaker changed the base branch from master to flutter-3.10-candidate.0 May 31, 2023 16:21
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests d: api docs Issues with https://api.flutter.dev/ documentation labels May 31, 2023
@flutter-dashboard flutter-dashboard bot added the f: gestures flutter/packages/flutter/gestures repository. label May 31, 2023
@reidbaker reidbaker changed the base branch from flutter-3.10-candidate.0 to flutter-3.10-candidate.18 May 31, 2023 16:22
@reidbaker reidbaker changed the base branch from flutter-3.10-candidate.18 to flutter-3.10-candidate.0 May 31, 2023 16:24
@reidbaker
Copy link
Contributor Author

reidbaker commented Jun 1, 2023

Test failing on infra keys. I think the right solution is to CP the new keys into this branch and for me to rebase.

@CaseyHillers
Copy link
Contributor

CaseyHillers commented Jun 6, 2023

@reidbaker this CP PR isn't mergeable in its current state. Can you rebase to only include the commit you are cherrypicking?

@gmackall gmackall mentioned this pull request Jun 6, 2023
Merged
8 tasks
@CaseyHillers
Copy link
Contributor

CaseyHillers commented Jun 9, 2023

@camsim99 @gmackall is this something you want to take over while Reid is OOO?

@camsim99 camsim99 changed the base branch from flutter-3.10-candidate.0 to flutter-3.10-candidate.1 June 12, 2023 16:54
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jun 12, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@camsim99
Copy link
Contributor

camsim99 commented Jun 12, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

This change has a test exemption on the original PR: #127628 (comment)

@camsim99 camsim99 requested a review from gmackall June 12, 2023 16:58
stuartmorgan-g
stuartmorgan-g approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 12, 2023
@auto-submit auto-submit bot merged commit d4276b9 into flutter:flutter-3.10-candidate.1 Jun 12, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2023
@engine-flutter-autoroll
d4276b9 [CP] Stable AGP 8.0 minification support when using integrati…
2867e0a 
…on_test package (flutter/flutter#127963)
@reidbaker reidbaker deleted the i127388-stable-cp branch July 6, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@gmackall gmackall gmackall approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: integration_test The flutter/packages/integration_test plugin f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@reidbaker @CaseyHillers @camsim99 @stuartmorgan-g @gmackall @itsjustkevin