[flutter_tools] update dart cache clear hint#128037
[flutter_tools] update dart cache clear hint#128037codenoid wants to merge 3 commits intoflutter:masterfrom codenoid:master
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
christopherfujino
left a comment
There was a problem hiding this comment.
Thanks for this fix. Can you add a test to this file that verifies the updated text is in the logger?
|
Your test is failing on CI: |
|
Thanks for submitting this, however, it was since fixed in #128171. |
|
Well that's break my heart But I understand that because of lack of skills, I'm not able to contribute the correct code as it suppose to be. Sincerely, codenoid |
It's definitely not because of a lack of skills. As this was a high profile bug, we had many PRs submitted to fix it, however only one had tests that were all passing, so I merged that one. Please don't be discouraged from contributing in the future. To maximize the odds your PR is merged, I would suggest:
Good luck! |
This pull request proposes to update the output message of
flutter doctorwhen encountering issues related to the Dart cache. Currently, it suggests using the commanddart pub cache clearwhich doesn't exist. Instead, it should recommend usingdart pub cache cleanas it is the correct command to clear Dart's cache.Steps to reproduce the issue:
flutter doctor.dart pub cache clear.Expected Result:
The output message should suggest running
dart pub cache cleanto clear Dart's cache.Actual Result:
The output message suggests running
dart pub cache clear, which is not a valid Dart command.Pre-launch Checklist
///).