should this check for selectionGeometry.status == SelectionStatus.uncollapsed

they don't select word? does the intention to collapse the selection at this globalPosition?

also this can be lastSecondaryTapDownPosition to be more readable

Yeah they do not, tested on chrome and wordpad/notepad. But good point about collapsing the selection, they only collapse the selection when right click happens outside of the currently active selection.

same here, should this collapse the selection?

Good point, only when the right-click happens outside of the current selection.

If you click in between selected lines, should it consider inside the selection?

Do you mean if I click in the overlap between the selections?

I mean if it is possible the line height is large that each line does not overlap. I am not sure if that is possible though.

I think it is possible given the current implementation.

This is due to getBoxesForSelection defaulting to SelectionHeightStyle.tight.

  List<ui.TextBox> getBoxesForSelection(
    TextSelection selection, {
    ui.BoxHeightStyle boxHeightStyle = ui.BoxHeightStyle.tight,
    ui.BoxWidthStyle boxWidthStyle = ui.BoxWidthStyle.tight,
  }) {
    assert(!debugNeedsLayout);
    _layoutTextWithConstraints(constraints);
    return _textPainter.getBoxesForSelection(
      selection,
      boxHeightStyle: boxHeightStyle,
      boxWidthStyle: boxWidthStyle,
    );
  }

In SelectableText and TextField these values are customizable. Setting to SelectionHeightStyle.max would result in this instead.

What I see on WordPad for windows is that it looks like they use SelectionHeightStyle.max.

Though I think adding this type of customizability can be done is a separate PR. I think if the line do not overlap it might be reasonable to expect that the gap is not within the selection?

I think if the line do not overlap it might be reasonable to expect that the gap is not within the selection?

I don't have an answer for this, since I am not sure if there is a native app that does SelectionHeightStyle.tight?

I am ok as-is, just want to make sure we are aware of this.

what coordinates are these rects in?

These should be in the local coordinates of the Selectable. I'll update the docs.

you can give it a default value of const <Rect>[] and make it not nullable.

are they in global coordinates? otherwise, don we need to do transformation?

They are in the local coordinates of the Selectable. I think this fits with the rest of the SelectionGeometry since the SelectionPoints are also in the local coordinates.

Oh are you saying if they are local coordinates then they must be transformed to the coordinates of the SelectableRegionContainerDelegate/global?

right

it guarantee to hasSelection if it is uncollapsed

You can just check _positionIsOnActiveSelection directly if the selectionRects is not nullable?

This should not be stored in global coordinates, but in local coordinates of SelectionContainer.

Either everything is stored in global coordinates starting from the selectionGeomery of _SelectableFragment, or everything is stored in local coordinates of the Selectable including the SelectionContainer.

Since other properties in SelectionGeometry are in local coordinate, this should too. Use getTransformFrom(selectables[index]) instead.

you can give it a default value of const <Rect>[] and make it not nullable.