Skip to content

Fix Slider overlay remains when unfocused#129115

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:fix_slider_unfocused_overlay
Jun 22, 2023
Merged

Fix Slider overlay remains when unfocused#129115
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:fix_slider_unfocused_overlay

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Jun 19, 2023

fixes #129016

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 19, 2023
@TahaTesser TahaTesser marked this pull request as ready for review June 19, 2023 21:25
@TahaTesser TahaTesser requested a review from Piinks June 19, 2023 21:25
Piinks
Piinks approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 21, 2023

auto label is removed for flutter/flutter, pr: 129115, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Jun 21, 2023

auto label is removed for flutter/flutter, pr: 129115, due to - The status or check suite Linux flutter_plugins has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 22, 2023
@auto-submit auto-submit bot merged commit d99e5fd into flutter:master Jun 22, 2023
@TahaTesser TahaTesser deleted the fix_slider_unfocused_overlay branch June 22, 2023 21:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
ddc73d8 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
6d086ac 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
62c7280 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
6406063 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
a842358 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
a0fdd3a 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
2c32156 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
d163ec9 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
060bd8e 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
ec226cd 
…129115)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
3456291 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
4c028bd 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
21f8ef2 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
33c5834 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
6ee6dd3 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
55fd668 
…129115)
@HansMuller HansMuller mentioned this pull request Jun 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
52d8590 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
04f6eb6 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
4187a16 
…129115)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
d99e5fd Fix Slider overlay remains when unfocused (flutter/flutter#…
bbd6e0d 
…129115)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slider remains active after interaction on web and desktop

2 participants

@TahaTesser @Piinks