[web] Migrate web-only initialization APIs by mdebbar · Pull Request #129856 · flutter/flutter

mdebbar · 2023-06-30T21:09:50Z

ui_web.warmupEngine
ui_web.setPluginHandler
ui_web.debugEmulateFlutterTesterEnvironment

ditman

LGTM, if CI is happy, let's go!!

ditman · 2023-07-05T22:58:43Z

  [+3876 ms] org-dartlang-app:/web_entrypoint.dart:19:16: Error: Method not found: 'warmupEngine'.
  [   +1 ms]   await ui_web.warmupEngine(
  [        ]                ^^^^^^^^^^^^
  [        ] Failed to compile application.

???

Is this still waiting for some changes in the engine to roll?

mdebbar · 2023-07-13T16:24:10Z

  [+3876 ms] org-dartlang-app:/web_entrypoint.dart:19:16: Error: Method not found: 'warmupEngine'.
  [   +1 ms]   await ui_web.warmupEngine(
  [        ]                ^^^^^^^^^^^^
  [        ] Failed to compile application.

???

Is this still waiting for some changes in the engine to roll?

Before landing the engine PR, I changed the name from warmupEngine to bootstrapEngine.

ditman

Still LGTM!

…29856)

- `ui_web.warmupEngine` - `ui_web.setPluginHandler` - `ui_web.debugEmulateFlutterTesterEnvironment`

This CP lands PR #129856 into `stable`. The PR above was part of a engine+framework change that got split in half during the stable cut, so now users are seeing some warnings that they can't act on. (Those warnings were only intended for people who were using our methods manually, rather than using normal flutter tooling). ## Issues Fixes #133069

[web] Migrate web-only initialization APIs

a7e8b0e

mdebbar requested a review from ditman June 30, 2023 21:09

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Jun 30, 2023

ditman approved these changes Jun 30, 2023

View reviewed changes

Merge branch 'master' into web_only_init

f14fcff

mdebbar added 2 commits July 13, 2023 12:22

warmupEngine => bootstrapEngine

28d8619

Merge branch 'main' into web_only_init

acbf497

ditman approved these changes Jul 13, 2023

View reviewed changes

mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023

auto-submit bot merged commit 87d5214 into flutter:master Jul 13, 2023

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

2a2ce62

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

7be072c

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

f447ce3

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b91aedb17579 (43 revisions) flutter/packages#4467

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

5c1ae4d

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 79119dfc66c6 (44 revisions) flutter/packages#4468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

d6befbc

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to a903f1defb15 (45 revisions) flutter/packages#4470

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

fed9a5f

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to d5e7f407e120 (47 revisions) flutter/packages#4471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

15acb6a

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 934d20864d07 (48 revisions) flutter/packages#4474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

634e3a8

…29856)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 56b5cc908304 (49 revisions) flutter/packages#4475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

da833e4

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

31aa09d

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

721ddd2

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

687d182

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

462a681

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

0fc86b9

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

ed5b4cf

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

7860350

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

64aba3e

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

d0823b1

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

867ea45

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

655bb49

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

53903bc

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

5125690

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

3936b23

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

26f69a4

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

c6a7978

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

c1cf23a

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

2b89984

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

2732025

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

59460de

…29856)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

87d5214 [web] Migrate web-only initialization APIs (flutter/flutter#1…

178f5ca

…29856)

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023

[web] Migrate web-only initialization APIs (flutter#129856)

2cf6400

- `ui_web.warmupEngine` - `ui_web.setPluginHandler` - `ui_web.debugEmulateFlutterTesterEnvironment`

ditman pushed a commit to ditman/flutter-flutter that referenced this pull request Sep 1, 2023

[web] Migrate web-only initialization APIs (flutter#129856)

0e9ea77

- `ui_web.warmupEngine` - `ui_web.setPluginHandler` - `ui_web.debugEmulateFlutterTesterEnvironment`

ditman mentioned this pull request Sep 1, 2023

[CP] Migrate web-only initialization APIs #133891

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] Migrate web-only initialization APIs#129856

[web] Migrate web-only initialization APIs#129856
auto-submit[bot] merged 4 commits intoflutter:masterfrom
mdebbar:web_only_init

mdebbar commented Jun 30, 2023 •

edited

Loading

Uh oh!

ditman left a comment

Uh oh!

ditman commented Jul 5, 2023

Uh oh!

mdebbar commented Jul 13, 2023

Uh oh!

ditman left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mdebbar commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

ditman commented Jul 5, 2023

Uh oh!

mdebbar commented Jul 13, 2023

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mdebbar commented Jun 30, 2023 •

edited

Loading