Roll dependencies to pick up updated vm_snapshot_analysis among others#130032
Closed
aam wants to merge 9 commits intoflutter:masterfrom
Closed
Roll dependencies to pick up updated vm_snapshot_analysis among others#130032aam wants to merge 9 commits intoflutter:masterfrom
aam wants to merge 9 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
a: tests
Contributor
|
There's also https://github.com/flutter/flutter/pull/129788/files and #129950 out to fix this, although they're all struggling to get presubmits red (the builds I've spot checked all look like unrelated flakes) |
Member
Author
|
This is obsolete due to #129788 |
github-actions
bot
added
engine
| sdk: flutter | ||
| platform: 3.1.0 | ||
| test: 1.24.3 | ||
| test: 1.24.4 |
Contributor
There was a problem hiding this comment.
It looks like bumping this is causing version solving on the plugins repo to fail:
Because test >=1.16.0-nullsafety.19 <1.16.6 depends on test_api 0.2.19 and test >=1.16.6 <1.17.10 depends on analyzer ^1.0.0, test >=1.16.0-nullsafety.19 <1.17.10 requires test_api 0.2.19 or analyzer ^1.0.0.
And because test >=1.17.10 <1.20.0 depends on analyzer >=1.0.0 <3.0.0 and test >=1.20.0 <1.21.2 depends on test_api 0.4.9, test >=1.16.0-nullsafety.19 <1.21.2 requires test_api 0.2.19 or 0.4.9 or analyzer >=1.0.0 <3.0.0.
And because test >=1.21.2 <1.21.3 depends on test_api 0.4.10 and test >=1.21.3 <1.21.4 depends on test_api 0.4.11, test >=1.16.0-nullsafety.19 <1.21.4 requires test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or analyzer >=1.0.0 <3.0.0.
And because test >=1.21.4 <1.21.5 depends on test_api 0.4.12 and test >=1.21.5 <1.21.6 depends on test_api 0.4.13, test >=1.16.0-nullsafety.19 <1.21.6 requires test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or analyzer >=1.0.0 <3.0.0.
And because test >=1.21.6 <1.21.7 depends on test_api 0.4.14 and test >=1.21.7 <1.22.0 depends on test_api 0.4.15, test >=1.16.0-nullsafety.19 <1.22.0 requires test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or 0.4.14 or 0.4.15 or analyzer >=1.0.0 <3.0.0.
And because test >=1.22.0 <1.22.1 depends on test_api 0.4.16 and test >=1.22.1 <1.22.2 depends on test_api 0.4.17, test >=1.16.0-nullsafety.19 <1.22.2 requires test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or 0.4.14 or 0.4.15 or 0.4.16 or 0.4.17 or analyzer >=1.0.0 <3.0.0.
And because test >=1.22.2 <1.24.0 depends on test_api 0.4.18 and test >=1.24.0 <1.24.3 depends on matcher >=0.12.15 <0.12.16, test >=1.16.0-nullsafety.19 <1.24.3 requires test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or 0.4.14 or 0.4.15 or 0.4.16 or 0.4.17 or 0.4.18 or analyzer >=1.0.0 <3.0.0 or matcher >=0.12.15 <0.12.16.
And because test >=1.24.3 <1.24.4 depends on test_api 0.6.0 and every version of flutter_test from sdk depends on matcher 0.12.16, if test >=1.16.0-nullsafety.19 <1.24.4 and flutter_test from sdk then test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or 0.4.14 or 0.4.15 or 0.4.16 or 0.4.17 or 0.4.18 or 0.6.0 or analyzer >=1.0.0 <3.0.0.
And because test >=1.24.4 depends on analyzer >=5.12.0 <7.0.0 and pigeon >=3.2.7 <7.0.5 depends on analyzer ^4.4.0, if pigeon >=3.2.7 <7.0.5 and flutter_test from sdk and test >=1.16.0-nullsafety.19 then test_api 0.2.19 or 0.4.9 or 0.4.10 or 0.4.11 or 0.4.12 or 0.4.13 or 0.4.14 or 0.4.15 or 0.4.16 or 0.4.17 or 0.4.18 or 0.6.0.
And because url_launcher_windows depends on flutter_test from sdk which depends on test_api 0.6.1, pigeon >=3.2.7 <7.0.5 is incompatible with test >=1.16.0-nullsafety.19.
So, because url_launcher_windows depends on both pigeon ^5.0.1 and test ^1.16.3, version solving failed.
Contributor
There was a problem hiding this comment.
@aam in order to roll vm_snapshot_analysis, maybe we should pin package:test with a TODO(fujino): roll flutter/packages deps
Member
Author
There was a problem hiding this comment.
I had a flutter/packages#4383 in mind as a fix for this.
aam
added a commit
to flutter/packages
that referenced
this pull request
Jul 7, 2023
Update pigeon dependency for url_launcher_windows. This is required to unblock flutter dependency update - see flutter/flutter#130032
github-actions
bot
added
a: text input
github-actions
bot
added
f: scrolling
github-actions
bot
removed
a: text input
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jul 7, 2023
…visions) (#43457)" (#43472) This reverts commit 5ae09b8 as the path forward is to roll manually to framework updating dependencies in the same PR. Roll of updated Dart SDK requires simultaneous update of flutter framework vm_snapshot_analysis dependency to 0.7.4. Trial run of that is flutter/flutter#130032
Contributor
|
Closing this because thanks to your upstream patches to flutter/packages, someone else was able to roll this forward. Thanks so much for all the work though! https://github.com/flutter/flutter/blob/master/dev/forbidden_from_release_tests/pubspec.yaml#L13 |
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
…visions) (flutter#43457)" (flutter#43472) This reverts commit 5ae09b8 as the path forward is to roll manually to framework updating dependencies in the same PR. Roll of updated Dart SDK requires simultaneous update of flutter framework vm_snapshot_analysis dependency to 0.7.4. Trial run of that is flutter/flutter#130032
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130009