Print pretty error when xcodebuild fails due to missing simulator by vashworth · Pull Request #130286 · flutter/flutter

vashworth · 2023-07-10T21:11:39Z

Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately.

If you try to run flutter and the simulator is missing, you'll get an error like

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
               		{ id:B1234A5C-67B8-901D-B2CB-FE34F56BDE78 }

               	Ineligible destinations for the "Runner" scheme:
               		{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 17.0 is not installed. To use with Xcode, first download and install the platform }

Print a pretty error to make it easier for developers to know what to do.

Part 2 of #129558.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hellohuanlin · 2023-07-12T22:02:58Z

packages/flutter_tools/lib/src/ios/mac.dart

+}
+
+String? _parseMissingPlatform(String message) {
+  final RegExp pattern = RegExp(r'error:(.*?) is not installed\. To use with Xcode, first download and install the platform');


this seems a bit fragile (e.g. apple updates this string). Is there any error code you can use instead?

Unfortunately no, there's nothing identifiable about it other than the message

Here's examples of the output/xcresult:

https://github.com/flutter/flutter/pull/130286/files#diff-d3f6153fa6dc8bb8da44d3b36e987346a3f92af86eed53babfcd91088f7e0d07R256-R270
https://github.com/flutter/flutter/pull/130286/files#diff-6dbb589bcbf47676289bc9a0c2103a8eef5debc5ee3090f6ab750c8af13a57b6R433

christopherfujino

sorry, i must have imagined i reviewed this but didn't. lgtm

…ator (#130286)" This reverts commit 604010e.

…ator" (#130504) Reverts #130286

…utter#130286) Starting in Xcode 15, the simulator is no longer included in Xcode and must be downloaded and installed separately. If you try to run flutter and the simulator is missing, you'll get an error like ``` xcodebuild: error: Unable to find a destination matching the provided destination specifier: { id:B1234A5C-67B8-901D-B2CB-FE34F56BDE78 } Ineligible destinations for the "Runner" scheme: { platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 17.0 is not installed. To use with Xcode, first download and install the platform } ``` Print a pretty error to make it easier for developers to know what to do. Part 2 of flutter#129558.

…ator" (flutter#130504) Reverts flutter#130286

…ator #130286" (#130506) Reland #130286 with fix. It failed the first time because of a discrepancy between the master branch and my branch (see #130504 (comment) for more info).

…ator (flutter/flutter#130286)

…ator flutter#130286" (flutter#130506) Reland flutter#130286 with fix. It failed the first time because of a discrepancy between the master branch and my branch (see flutter#130504 (comment) for more info).

vashworth added 2 commits July 10, 2023 15:58

check for missing simulator xcodebuild error

e97041d

move reused code to function

5dea619

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 10, 2023

another test

7e56bd0

vashworth marked this pull request as ready for review July 11, 2023 14:32

vashworth requested a review from christopherfujino July 11, 2023 14:33

vashworth mentioned this pull request Jul 11, 2023

Flutter won't run until iOS 17 simulator is installed with Xcode 15 #129558

Closed

4 tasks

vashworth requested a review from hellohuanlin July 12, 2023 20:14

hellohuanlin reviewed Jul 12, 2023

View reviewed changes

christopherfujino approved these changes Jul 12, 2023

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023

auto-submit bot merged commit 604010e into flutter:master Jul 13, 2023

vashworth added a commit that referenced this pull request Jul 13, 2023

Revert "Print pretty error when xcodebuild fails due to missing simul…

99ebf0f

…ator (#130286)" This reverts commit 604010e.

vashworth mentioned this pull request Jul 13, 2023

Revert "Print pretty error when xcodebuild fails due to missing simulator" #130504

Merged

auto-submit bot pushed a commit that referenced this pull request Jul 13, 2023

Revert "Print pretty error when xcodebuild fails due to missing simul…

ab86c79

…ator" (#130504) Reverts #130286

vashworth mentioned this pull request Jul 13, 2023

Reland "Print pretty error when xcodebuild fails due to missing simulator #130286" #130506

Merged

8 tasks

LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023

Revert "Print pretty error when xcodebuild fails due to missing simul…

b334efc

…ator" (flutter#130504) Reverts flutter#130286

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b8fa92338629 (39 revisions) flutter/packages#4464

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

29331b2

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 5cbccc4d790a (41 revisions) flutter/packages#4465

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

aa1ac0e

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to f5a5581fdbae (42 revisions) flutter/packages#4466

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

46061a1

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to b91aedb17579 (43 revisions) flutter/packages#4467

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

4709228

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 79119dfc66c6 (44 revisions) flutter/packages#4468

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

c505284

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

91990c9

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to d5e7f407e120 (47 revisions) flutter/packages#4471

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

f8bcd95

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 934d20864d07 (48 revisions) flutter/packages#4474

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

240eb4e

…ator (flutter/flutter#130286)

engine-flutter-autoroll mentioned this pull request Jul 14, 2023

Roll Flutter from c40173f114fa to 56b5cc908304 (49 revisions) flutter/packages#4475

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

3becf48

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

90d85fc

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

05ada93

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

9c67870

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

0810be5

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

48ba750

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

b7470f6

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

36d97c1

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

bdc7751

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

98bf696

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

1aed63d

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

691ed48

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

bff6d4b

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

cb257d3

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

7a49c68

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

d8a0725

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

06bbe5f

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

dadad58

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

27219fe

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

c037f34

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

c2c82a5

…ator (flutter/flutter#130286)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

604010e Print pretty error when xcodebuild fails due to missing simul…

3366037

…ator (flutter/flutter#130286)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print pretty error when xcodebuild fails due to missing simulator#130286

Print pretty error when xcodebuild fails due to missing simulator#130286
auto-submit[bot] merged 3 commits intoflutter:masterfrom
vashworth:missing_ios_17_sim_err_message

vashworth commented Jul 10, 2023 •

edited

Loading

Uh oh!

hellohuanlin Jul 12, 2023

Uh oh!

vashworth Jul 12, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vashworth commented Jul 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

vashworth Jul 12, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Jul 10, 2023 •

edited

Loading