Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 by QuncCccccc · Pull Request #130464 · flutter/flutter

QuncCccccc · 2023-07-13T01:12:05Z

Updated unit tests for DropdownMenu, SnackBarTheme and Stepper to have M2 and M3 versions.

More info in #127064

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

HansMuller

LGTM

TahaTesser · 2023-07-14T08:21:35Z

packages/flutter/test/material/stepper_test.dart

+    const String cancelStr = 'Cancel';
    expect(buttonMaterial(continueStr).color!.value, 0);
-    expect(buttonMaterial(continueStr).textStyle!.color!.value, material3Light ? themeLight.colorScheme.onSurface.withOpacity(0.38).value : 0x61000000);
+    expect(buttonMaterial(continueStr).textStyle!.color!.value, themeLight.colorScheme.onSurface.withOpacity(0.38).value);


This and similar lines are very long and exceed 80 characters maximum.

https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#prefer-a-maximum-line-length-of-80-characters

We could get the button's Material in a variable once and check its properties instead of calling buttonMaterial(continueStr) on every check and we can also make a colorScheme variable instead of calling themeLight.colorScheme on every check. This way it'd be readable and still fit in a single line.

Something like this:

expect(_buttonMaterial.color!.value, 0); expect(_buttonMaterial.textStyle!.color!.value, _colorScheme.onSurface.withOpacity(0.38).value);

auto-submit · 2023-07-14T08:24:25Z

auto label is removed for flutter/flutter, pr: 130464, due to This PR has not met approval requirements for merging. Changes were requested by {TahaTesser}, please make the needed changes and resubmit this PR.
You are a member of flutter-hackers and need 0 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

TahaTesser

LGTM!

…r M2/M3 (flutter/flutter#130464)

Manual roll requested by [email protected] flutter/flutter@f842ed9...6f09064 2023-07-17 [email protected] Stand-alone widget tree with multiple render trees to enable multi-view rendering (flutter/flutter#125003) 2023-07-17 [email protected] Update to valid build tools variant and update lockfiles (flutter/flutter#125825) 2023-07-17 [email protected] Roll Packages from 369ee7e to 6889cca (5 revisions) (flutter/flutter#130721) 2023-07-17 [email protected] [Reland] - Update `DialogTheme` tests for M2/M3 (flutter/flutter#130711) 2023-07-17 [email protected] Roll Flutter Engine from 683087731feb to e4cae43c9c7a (9 revisions) (flutter/flutter#130716) 2023-07-17 [email protected] [flutter_tools] Support coverage collection for dependencies (flutter/flutter#129513) 2023-07-17 [email protected] Fix `DatePicker` uses incorrect overlay color from `DatePickerTheme` and add missing tests (flutter/flutter#130584) 2023-07-17 [email protected] Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3 (flutter/flutter#130464) 2023-07-17 [email protected] Clarify the whole "CustomPainters default to Size.zero" thing. (flutter/flutter#130624) 2023-07-16 [email protected] Update list of CoC contacts. (flutter/flutter#130630) 2023-07-15 [email protected] Manual roll Flutter Engine from 403866d16137 to 683087731feb (16 revisions) (flutter/flutter#130666) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#130464) Updated unit tests for `DropdownMenu`, `SnackBarTheme` and `Stepper` to have M2 and M3 versions. More info in flutter#127064

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 13, 2023

QuncCccccc marked this pull request as ready for review July 13, 2023 17:24

QuncCccccc requested review from HansMuller and TahaTesser July 13, 2023 21:26

HansMuller approved these changes Jul 13, 2023

View reviewed changes

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 13, 2023

QuncCccccc added 4 commits July 13, 2023 17:48

Update tests for M2/M3

129f18b

Update tests for M2/M3

6d47859

Update tests for M2/M3

ca159e3

Fix failed tests

d7e17a3

QuncCccccc force-pushed the update_dropdown_menu_tests branch from 85546be to d7e17a3 Compare July 14, 2023 00:48

TahaTesser suggested changes Jul 14, 2023

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023

QuncCccccc added 2 commits July 14, 2023 14:47

Update PR comments

45f822e

Update

e455612

QuncCccccc requested a review from TahaTesser July 14, 2023 21:50

TahaTesser approved these changes Jul 17, 2023

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2023

auto-submit bot merged commit f4da096 into master Jul 17, 2023

auto-submit bot deleted the update_dropdown_menu_tests branch July 17, 2023 08:07

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 3a1190a5a85c (72 revisions) flutter/packages#4492

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

2baff83

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 526522d9e5c7 (74 revisions) flutter/packages#4493

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

665ffae

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7a42ed7ef6ed (76 revisions) flutter/packages#4495

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

fe76103

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 6f09064e785b (77 revisions) flutter/packages#4496

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

3f8d193

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 083d18e83f8f (78 revisions) flutter/packages#4497

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

24636f9

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 7937b1d51f7b (80 revisions) flutter/packages#4498

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

64345eb

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to b2e22d3558e8 (85 revisions) flutter/packages#4499

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

ca1d53a

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 17, 2023

Roll Flutter from c40173f114fa to 0df4496cdb50 (87 revisions) flutter/packages#4500

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

d6ccfdb

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 203ef6f7a32f (111 revisions) flutter/packages#4503

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

4285ed8

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 3b0b8348fd3e (112 revisions) flutter/packages#4505

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

e690eea

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 8b768de18f29 (113 revisions) flutter/packages#4506

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

4f11499

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to 86385dce684e (114 revisions) flutter/packages#4507

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

9115533

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 18, 2023

Roll Flutter from c40173f114fa to b460d49199e5 (115 revisions) flutter/packages#4508

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

afeda30

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

d620d90

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

d23684d

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

e1c98cb

…r M2/M3 (flutter/flutter#130464)

engine-flutter-autoroll mentioned this pull request Jul 19, 2023

Manual roll Flutter from f842ed916514 to 6f09064e785b (11 revisions) flutter/packages#4518

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2023

f4da096 Update DropdownMenu, SnackBarTheme and Stepper tests fo…

e79639a

…r M2/M3 (flutter/flutter#130464)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3#130464

Update `DropdownMenu`, `SnackBarTheme` and `Stepper` tests for M2/M3#130464
auto-submit[bot] merged 6 commits intomasterfrom
update_dropdown_menu_tests

QuncCccccc commented Jul 13, 2023

Uh oh!

HansMuller left a comment

Uh oh!

TahaTesser Jul 14, 2023

Uh oh!

TahaTesser Jul 14, 2023 •

edited

Loading

Uh oh!

auto-submit bot commented Jul 14, 2023

Uh oh!

TahaTesser left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

QuncCccccc commented Jul 13, 2023

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser Jul 14, 2023

Choose a reason for hiding this comment

Uh oh!

TahaTesser Jul 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 14, 2023

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TahaTesser Jul 14, 2023 •

edited

Loading