Skip to content

Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog.#130484

Merged
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ronnnnn:feat-date-picker-barrier-color
Jul 25, 2023
Merged

Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog.#130484
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ronnnnn:feat-date-picker-barrier-color

Conversation

@ronnnnn
Copy link
Contributor

@ronnnnn ronnnnn commented Jul 13, 2023

Overview

Add barrierDismissible, barrierColor and barrierLabel parameters to showDatePicker, showTimePicker and showAboutDialog which calls showDialog internally.
We can change these parameters with showDialog and Dialog widgets (like DatePickerDialog, TimePickerDialog or AboutDialog) directly. But, I think it is prefer to provide interfaces same as showDialog to keep application wide unified looks if it is used internally.

Fixes #130971

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom barrier color with showDatePicker, showTimePicker and showAboutDialog

3 participants