Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog.#130484
Merged
auto-submit[bot] merged 10 commits intoflutter:masterfrom Jul 25, 2023
ronnnnn:feat-date-picker-barrier-color
Merged
Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog.#130484auto-submit[bot] merged 10 commits intoflutter:masterfrom ronnnnn:feat-date-picker-barrier-color
auto-submit[bot] merged 10 commits intoflutter:masterfrom
ronnnnn:feat-date-picker-barrier-color
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
barrierDismissible,barrierColorandbarrierLabelparameters toshowDatePicker,showTimePickerandshowAboutDialogwhich callsshowDialoginternally.We can change these parameters with
showDialogand Dialog widgets (likeDatePickerDialog,TimePickerDialogorAboutDialog) directly. But, I think it is prefer to provide interfaces same asshowDialogto keep application wide unified looks if it is used internally.Fixes #130971
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.