Fix material date picker behavior when changing year by Lexycon · Pull Request #130486 · flutter/flutter

Lexycon · 2023-07-13T10:09:42Z

This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (#81547)

See material component guideline for the date picker: Material component date-picker behavior
See also: Material components android discussion

When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated.

So here is my suggestion:
It will try to preselect the day like the native picker:

respecting the boundaries of the date picker (firstDate, lastDate)
changing from leapyear 29th february will set 28th february if not a leapyear is selected
only set the day if it is selectable (selectableDayPredicate)

The calendar shown in the recording was setup with this parameters:

firstDate: DateTime(2016, DateTime.june, 9),
initialDate: DateTime(2018, DateTime.may, 4),
lastDate: DateTime(2021, DateTime.january, 15),

Android-Date-Picker-changes.mov

Fixes #81547

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

…le. Respects boundaries of firstDate and lastDate.

HansMuller

Looks like a good fix. @TahaTesser - please take a look

TahaTesser

Minor nits

packages/flutter/lib/src/material/calendar_date_picker.dart

Co-authored-by: Taha Tesser <[email protected]>

TahaTesser

LGTM

…/flutter#130486)

flutter/flutter@d7ed5dc...9def8f6 2023-07-25 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#130484) 2023-07-25 [email protected] Roll Flutter Engine from a7a842ee9ccd to 036c58f79307 (1 revision) (flutter/flutter#131244) 2023-07-25 [email protected] Roll Flutter Engine from 3baca2fe55c8 to a7a842ee9ccd (1 revision) (flutter/flutter#131243) 2023-07-25 [email protected] Roll Flutter Engine from 9a0192d965e0 to 3baca2fe55c8 (1 revision) (flutter/flutter#131241) 2023-07-25 [email protected] Roll Flutter Engine from ceb2674e82b4 to 9a0192d965e0 (3 revisions) (flutter/flutter#131230) 2023-07-25 [email protected] Roll Flutter Engine from 4fded78e5a01 to ceb2674e82b4 (2 revisions) (flutter/flutter#131229) 2023-07-25 [email protected] Roll Flutter Engine from ff02fa72acce to 4fded78e5a01 (2 revisions) (flutter/flutter#131225) 2023-07-24 [email protected] Roll Flutter Engine from a489c7496268 to ff02fa72acce (1 revision) (flutter/flutter#131221) 2023-07-24 [email protected] Roll Flutter Engine from 815b97157dc7 to a489c7496268 (3 revisions) (flutter/flutter#131218) 2023-07-24 [email protected] Roll Flutter Engine from 2b8d83fa20e3 to 815b97157dc7 (5 revisions) (flutter/flutter#131214) 2023-07-24 [email protected] Use toStringAsFixed in DecorationImage.toString (flutter/flutter#131026) 2023-07-24 [email protected] Roll Flutter Engine from aa876f6bec69 to 2b8d83fa20e3 (3 revisions) (flutter/flutter#131207) 2023-07-24 [email protected] Fix M3 TimePicker dial background uses incorrect color (flutter/flutter#131045) 2023-07-24 [email protected] Fix floating SnackBar throws when FAB is on the top (flutter/flutter#129274) 2023-07-24 [email protected] Update link to unbounded constraints error (flutter/flutter#131205) 2023-07-24 [email protected] Optimize SliverMainAxisGroup/SliverCrossAxisGroup paint function (flutter/flutter#129310) 2023-07-24 [email protected] [DropdownMenu] Close menu after editing is complete (flutter/flutter#130710) 2023-07-24 [email protected] Reduce usage of testUsingContext (flutter/flutter#131078) 2023-07-24 [email protected] Roll Packages from 2266a76 to 8028caf (13 revisions) (flutter/flutter#131196) 2023-07-24 [email protected] Fix material date picker behavior when changing year (flutter/flutter#130486) 2023-07-24 [email protected] Update Gallery demo app themes for Material3 compatibility (flutter/flutter#131093) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR changes the material date picker behavior when changing the year so that it matches the native picker and the material component guideline. (flutter#81547) See material component guideline for the date picker: [Material component date-picker behavior](https://m3.material.io/components/date-pickers/guidelines#1531a81f-4052-4a75-a20d-228c7e110156) See also: [Material components android discussion](material-components/material-components-android#1723) When selecting another year in the native picker, the same day will be selected (by respecting the boundaries of the date picker). The current material date picker does not select any day when changing the year. This will lead to confusion if the user presses OK and the year does not get updated. So here is my suggestion: It will try to preselect the day like the native picker: - respecting the boundaries of the date picker (firstDate, lastDate) - changing from leapyear 29th february will set 28th february if not a leapyear is selected - only set the day if it is selectable (selectableDayPredicate) The calendar shown in the recording was setup with this parameters: ``` firstDate: DateTime(2016, DateTime.june, 9), initialDate: DateTime(2018, DateTime.may, 4), lastDate: DateTime(2021, DateTime.january, 15), ``` https://github.com/flutter/flutter/assets/13588771/3041c296-b9d0-4078-88cd-d1135fc343b3 Fixes flutter#81547

Fix changing year does change the selected day if the day is selectab…

f5e52e3

…le. Respects boundaries of firstDate and lastDate.

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 13, 2023

dberchtenbreiter-beurer added 2 commits July 13, 2023 13:18

Fix getting preferredDay by using math.min instead of clamp.

9742cb3

Fix date picker test -> year does change the selected date.

b3cd9de

Lexycon changed the title ~~Fix material date picker changing year behavior~~ Fix material date picker behavior when changing year Jul 13, 2023

HansMuller requested review from HansMuller and TahaTesser July 21, 2023 23:06

HansMuller approved these changes Jul 21, 2023

View reviewed changes

TahaTesser suggested changes Jul 24, 2023

View reviewed changes

packages/flutter/lib/src/material/calendar_date_picker.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/calendar_date_picker.dart Outdated Show resolved Hide resolved

Lexycon and others added 3 commits July 24, 2023 11:20

Update packages/flutter/lib/src/material/calendar_date_picker.dart

fcc3564

Co-authored-by: Taha Tesser <[email protected]>

Update packages/flutter/lib/src/material/calendar_date_picker.dart

0ecec0e

Co-authored-by: Taha Tesser <[email protected]>

Merge branch 'master' into fix81547

cc32c37

TahaTesser approved these changes Jul 24, 2023

View reviewed changes

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 24, 2023

auto-submit bot merged commit 2a1f26c into flutter:master Jul 24, 2023

Lexycon deleted the fix81547 branch July 25, 2023 10:52

engine-flutter-autoroll mentioned this pull request Jul 25, 2023

Roll Flutter from d7ed5dc2e212 to c8b9b15e4cd1 (20 revisions) flutter/packages#4560

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2023

2a1f26c Fix material date picker behavior when changing year (flutter…

c8f90cc

…/flutter#130486)

engine-flutter-autoroll mentioned this pull request Jul 25, 2023

Roll Flutter from d7ed5dc2e212 to 9def8f6bc56b (21 revisions) flutter/packages#4561

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2023

2a1f26c Fix material date picker behavior when changing year (flutter…

bbe124e

…/flutter#130486)

HansMuller mentioned this pull request Jul 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix material date picker behavior when changing year#130486

Fix material date picker behavior when changing year#130486
auto-submit[bot] merged 6 commits intoflutter:masterfrom
Lexycon:fix81547

Lexycon commented Jul 13, 2023 •

edited by HansMuller

Loading

Uh oh!

HansMuller left a comment

Uh oh!

TahaTesser left a comment

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Lexycon commented Jul 13, 2023 • edited by HansMuller Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Lexycon commented Jul 13, 2023 •

edited by HansMuller

Loading