Skip to content

Add Images demo to the gallery app.#13141

Merged
amirh merged 5 commits intoflutter:masterfrom
amirh:gallery-images
Nov 29, 2017
Merged

Add Images demo to the gallery app.#13141
amirh merged 5 commits intoflutter:masterfrom
amirh:gallery-images

Conversation

@amirh
Copy link
Contributor

@amirh amirh commented Nov 22, 2017

We are still waiting for the final assets to use, for now I just used
some place holders.

@amirh
Add Images demo to the gallery app.
02a505b 
We are still waiting for the final assets to use, for now I just used
some place holders.
@amirh amirh requested a review from HansMuller November 22, 2017 01:22
HansMuller
HansMuller approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to update the demos lists in examples/flutter_gallery/test/live_smoketest.dart and examples/flutter_gallery/test_driver/transitions_perf_test.dart

examples/flutter_gallery/lib/gallery/item.dart Outdated
// Media
new GalleryItem(
title: 'Images',
subtitle: 'Static and animated images',
Copy link
Contributor

@HansMuller HansMuller Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This demo is just about animated images, so maybe adjust the title/subtitle

@amirh
Copy link
Contributor Author

amirh commented Nov 22, 2017

Thanks, I addressed the comments.

I'm waiting for the final assets before submitting this.
@sethladd - FYI

Hixie
Hixie reviewed Nov 22, 2017
View reviewed changes
examples/flutter_gallery/test/live_smoketest.dart Outdated
const Demo('Sliders'),
const Demo('Switches'),

//Media
Copy link
Contributor

@Hixie Hixie Nov 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: missing space

Copy link
Contributor Author

@amirh amirh Nov 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@amirh amirh force-pushed the gallery-images branch 3 times, most recently from d44ddbb to 9e1543e Compare November 29, 2017 00:17
@HansMuller
Copy link
Contributor

HansMuller commented Nov 29, 2017

LGTM

@amirh amirh merged commit 47b5c37 into flutter:master Nov 29, 2017
amirh added a commit to amirh/flutter that referenced this pull request Nov 29, 2017
@amirh
Fix 'Animated images' demo name in Gallery's test.
f809db6 
In flutter#13141 I updated the demo name
from 'Animated Images' to 'Animated images' before submitted, but did
not update the name in the smoketest and transitions_perf test.
@amirh amirh mentioned this pull request Nov 29, 2017
Merged
amirh added a commit that referenced this pull request Nov 29, 2017
@amirh
Fix 'Animated images' demo name in Gallery's test. (#13240)
4f240a4 
In #13141 I updated the demo name
from 'Animated Images' to 'Animated images' before submitted, but did
not update the name in the smoketest and transitions_perf test.
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@amirh
Add Images demo to the gallery app. (flutter#13141)
d183056
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
@amirh
Fix 'Animated images' demo name in Gallery's test. (flutter#13240)
e969eb9 
In flutter#13141 I updated the demo name
from 'Animated Images' to 'Animated images' before submitted, but did
not update the name in the smoketest and transitions_perf test.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2019
@engine-flutter-autoroll
540c6c1 Revert "Enable/tweak web sdk source maps (flutter#13141)" (fl…
b588c9a 
…utter/engine#13148)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 16, 2019
Merged
engine-flutter-autoroll added a commit that referenced this pull request Oct 16, 2019
@engine-flutter-autoroll
Roll engine 540fc97..5e6c005 (33 commits) (#42853)
1dc09e4 
[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005

git log 540fc97..5e6c005 --no-merges --oneline
2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (#13123)" (flutter/engine#13146)
2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (#13141)" (flutter/engine#13148)
2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine 540fc97..5e6c005 (33 commits) (flutter#42853)
a686e4b 
[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005

git log 540fc97..5e6c005 --no-merges --oneline
2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (flutter#13123)" (flutter/engine#13146)
2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (flutter#13141)" (flutter/engine#13148)
2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Hixie Hixie Hixie left review comments

+1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amirh @HansMuller @Hixie @googlebot