Add hover duration for `Inkwell` widget by whiskeyPeak · Pull Request #132176 · flutter/flutter

whiskeyPeak · 2023-08-08T23:29:43Z

Adds a hoverDuration property to the Inkwell widget. This allows the user to customise how long the change in colour animates between the default colour and the hovered colour.

simplescreenrecorder-2023-08-09_00.31.18.mp4

Fixes #132170

…n-inkwell

HansMuller

Looks like a good change. One small request.

HansMuller · 2023-08-09T18:44:10Z

packages/flutter/lib/src/material/ink_well.dart

    this.onFocusChange,
    this.autofocus = false,
    this.statesController,
+    this.hoverDuration = const Duration(milliseconds: 50),


Prefer to make this default to null and introduce the default with hoverDuration ?? const Duration(milliseconds: 50). That will make it easier to override the default via a theme later.

…n-inkwell

HansMuller

LGTM

auto-submit · 2023-08-11T17:48:39Z

auto label is removed for flutter/flutter/132176, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

justinmc

LGTM, just a nit and a question.

justinmc · 2023-08-14T18:15:28Z

packages/flutter/lib/src/material/ink_well.dart

  /// {@endtemplate}
  final MaterialStatesController? statesController;

+  /// The duration of the animation that animates the hover effect.


Nit: Maybe state that the default is 50 milliseconds.

justinmc · 2023-08-14T18:21:00Z

packages/flutter/test/material/ink_well_test.dart

+    await tester.tap(find.byType(InkWell), pointer: 1);
+    await tester.pump(const Duration(seconds: 1));
+
+    expect(log, equals(<String>['tap']));


Could you explain how this test works? Would it actually fail without the change in this PR? I expected it to test a color or something.

The test would fail without this pr because it's making use of the new hoverDuration property.

HansMuller

Will land the API doc change that Justin asked for (default hoverDuration is 50ms)

packages/flutter/lib/src/material/ink_well.dart

flutter/flutter@deeb811...61d9f55 2023-08-25 [email protected] Update flutter packages to pick up latest vm_service (flutter/flutter#133335) 2023-08-25 [email protected] Roll Flutter Engine from 00f532dcaef4 to 33fca02451ef (1 revision) (flutter/flutter#133337) 2023-08-25 [email protected] Roll Flutter Engine from cb58abd77326 to 00f532dcaef4 (3 revisions) (flutter/flutter#133333) 2023-08-25 [email protected] Fix `PopupMenuItem` with a `ListTile` doesn't use the correct style. (flutter/flutter#133141) 2023-08-25 [email protected] Fix `Chip.shape`'s side is not used when provided in Material 3 (flutter/flutter#132941) 2023-08-25 [email protected] Dispose overlay entries (flutter/flutter#132826) 2023-08-25 [email protected] Roll Flutter Engine from 0f8962208a44 to cb58abd77326 (3 revisions) (flutter/flutter#133320) 2023-08-25 [email protected] Roll Flutter Engine from 09e620d26834 to 0f8962208a44 (2 revisions) (flutter/flutter#133309) 2023-08-25 [email protected] Roll Flutter Engine from 9bcefc74b772 to 09e620d26834 (1 revision) (flutter/flutter#133307) 2023-08-25 [email protected] Roll Flutter Engine from 1382d6d79408 to 9bcefc74b772 (2 revisions) (flutter/flutter#133305) 2023-08-25 [email protected] Allow passing verbose log from flutter daemon. (flutter/flutter#132828) 2023-08-25 [email protected] Roll Flutter Engine from b8ec4da8866c to 1382d6d79408 (1 revision) (flutter/flutter#133298) 2023-08-25 [email protected] Roll Flutter Engine from 965501a25d92 to b8ec4da8866c (11 revisions) (flutter/flutter#133296) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3.5.3 to 3.6.0 (flutter/flutter#133281) 2023-08-24 [email protected] Update the tool to know about all our new platforms (flutter/flutter#132423) 2023-08-24 [email protected] l10n-related documentation improvements (flutter/flutter#133114) 2023-08-24 [email protected] Add hover duration for `Inkwell` widget (flutter/flutter#132176) 2023-08-24 [email protected] [web] benchmark the benchmark harness overhead (flutter/flutter#132999) 2023-08-24 [email protected] Users of ChangeNotifier should dispatch event of object creation in constructor. (flutter/flutter#133210) 2023-08-24 49699333+dependabot[bot]@users.noreply.github.com Bump activesupport from 6.1.7.3 to 6.1.7.6 in /dev/ci/mac (flutter/flutter#133225) 2023-08-24 [email protected] Remove `ImageProvider.load`, `DecoderCallback` and `PaintingBinding.instantiateImageCodec` (flutter/flutter#132679) 2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 965501a25d92 (24 revisions) (flutter/flutter#133272) 2023-08-24 [email protected] handle exceptions raised while searching for configured android studio (flutter/flutter#133180) 2023-08-24 [email protected] Fix mac tool_integration_tests with Xcode 15 (flutter/flutter#133217) 2023-08-24 [email protected] Roll Packages from 3060b1a to 383bffa (3 revisions) (flutter/flutter#133256) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

huanghui1998hhh · 2024-08-05T07:05:47Z

Consider add it to ThemeData?

whiskeyPeak added 2 commits August 9, 2023 00:07

init commit

f788714

add test

f05e93a

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 8, 2023

Merge remote-tracking branch 'upstream/master' into add-hover-duratio…

024ba90

…n-inkwell

HansMuller reviewed Aug 9, 2023

View reviewed changes

whiskeyPeak added 2 commits August 9, 2023 20:36

make hoverDuration null

c6720e8

Merge remote-tracking branch 'upstream/master' into add-hover-duratio…

ace8996

…n-inkwell

whiskeyPeak requested a review from HansMuller August 9, 2023 19:39

HansMuller approved these changes Aug 9, 2023

View reviewed changes

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2023

justinmc approved these changes Aug 14, 2023

View reviewed changes

HansMuller approved these changes Aug 21, 2023

View reviewed changes

packages/flutter/lib/src/material/ink_well.dart Show resolved Hide resolved

HansMuller and others added 3 commits August 21, 2023 10:00

Update packages/flutter/lib/src/material/ink_well.dart

ccb62f5

Merge branch 'master' into add-hover-duration-inkwell

780da4e

Merge branch 'master' into add-hover-duration-inkwell

f31ff84

HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 24, 2023

auto-submit bot merged commit b211891 into flutter:master Aug 24, 2023

engine-flutter-autoroll mentioned this pull request Aug 25, 2023

Roll Flutter from deeb811ef0bb to ea0052193942 (22 revisions) flutter/packages#4772

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023

b211891 Add hover duration for Inkwell widget (flutter/flutter#132176)

0757168

engine-flutter-autoroll mentioned this pull request Aug 25, 2023

Roll Flutter from deeb811ef0bb to db22617b7292 (23 revisions) flutter/packages#4773

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023

b211891 Add hover duration for Inkwell widget (flutter/flutter#132176)

76e78a8

engine-flutter-autoroll mentioned this pull request Aug 25, 2023

Roll Flutter from deeb811ef0bb to 61d9f5566559 (25 revisions) flutter/packages#4774

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2023

b211891 Add hover duration for Inkwell widget (flutter/flutter#132176)

f70d8ac

HansMuller mentioned this pull request Aug 25, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

b211891 Add hover duration for Inkwell widget (flutter/flutter#132176)

f7ed4fc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add hover duration for `Inkwell` widget#132176

Add hover duration for `Inkwell` widget#132176
auto-submit[bot] merged 8 commits intoflutter:masterfrom
whiskeyPeak:add-hover-duration-inkwell

whiskeyPeak commented Aug 8, 2023 •

edited

Loading

Uh oh!

HansMuller left a comment

Uh oh!

HansMuller Aug 9, 2023

Uh oh!

whiskeyPeak Aug 9, 2023

Uh oh!

HansMuller left a comment

Uh oh!

auto-submit bot commented Aug 11, 2023

Uh oh!

justinmc left a comment

Uh oh!

justinmc Aug 14, 2023

Uh oh!

justinmc Aug 14, 2023

Uh oh!

whiskeyPeak Aug 16, 2023

Uh oh!

HansMuller left a comment

Uh oh!

Uh oh!

huanghui1998hhh commented Aug 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

whiskeyPeak commented Aug 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

HansMuller Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

whiskeyPeak Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 11, 2023

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

whiskeyPeak Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

huanghui1998hhh commented Aug 5, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

whiskeyPeak commented Aug 8, 2023 •

edited

Loading