Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus#132273
Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus#132273justinmc wants to merge 10 commits intoflutter:masterfrom
Conversation
…Focus (flutter#130164) Simplifying the TextField API.
github-actions
bot
added
a: text input
|
@LongCatIsLooong @Renzo-Olivares This came up during triage the other day. Do you happen to know if this is still something we plan to do? |
|
Not sure but the change makes sense to me. I can try relanding this. |
justinmc
force-pushed
the
reland-can-request-focus-dropdown
branch
from
575ffaa to
7748d34
Compare
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
I'm closing this as I'm unable to fix the Google failures, unfortunately. I've created an issue to track this for the future. #149067 |
We made a breaking change to remove `TextField.canRequestFocus` (flutter/flutter#130164). However, this caused a google3 failure and was reverted (flutter/flutter#132104). This removes the breaking change guide since we never relanded this change: * flutter/flutter#149067 * flutter/flutter#132273
3 participants
Relands #130164 by reverting #132106.
It seems like there were legitimate Google test failures that I'll probably need to fix with a g3fix.
Fixes #130011