Fix Xcode Debug integration tests#132318
Closed
vashworth wants to merge 11 commits intoflutter:masterfrom
Closed
Conversation
github-actions
bot
added
platform-ios
vashworth
changed the title
fluttermirroringbot
pushed a commit
that referenced
this pull request
Aug 11, 2023
Temporarily removes Xcode debug tests. Xcode tests are currently failing in CI for some infra-related issues. I have a fix for it (#132318) that I confirmed worked in presubmit, but I think the logic is better suited to live in recipes. However, it's going to be a bit of a learning curve to update recipes and might take me a couple days so disabling them in the meantime. Tracking issue to readd when ready: #132309
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Xcode debug integration tests by using an older version of Xcode that is compatible with the host OS.
Also, dismisses permission dialog and temporarily gives access to control Xcode.
FYI: I temporarily tested the tests in presubmit to make sure they pass:
https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20integration_ui_ios_driver_xcode_debug/3/overview
https://ci.chromium.org/ui/p/flutter/builders/try/Mac_ios%20flutter_gallery_ios__start_up_xcode_debug/5/overview
Fixes #132309.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.