[Framework] Add Share to selection controls by LouiseHsu · Pull Request #132599 · flutter/flutter

LouiseHsu · 2023-08-15T22:24:39Z

In native iOS, users are able to select text and initiate a share menu, which provides several standard services, such as copy, sharing to social media, direct ability to send to various contacts through messaging apps, etc.

Simulator.Screen.Recording.-.iPhone.14.Pro.Max.-.2023-08-09.at.18.47.02.mp4

This PR is the framework portion of the changes that will allow Share to be implemented.
The corresponding merged engine PR is here
This PR addresses #107578
More details are available in this design doc

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the [CLA].
All existing and new tests are passing.

hellohuanlin

lgtm after addressing those comments

packages/flutter/lib/src/material/material_localizations.dart

hellohuanlin · 2023-08-17T17:42:31Z

packages/flutter/lib/src/material/material_localizations.dart

  String get searchWebButtonLabel => 'Search Web';

+  @override
+  String get shareButtonLabel => 'Share...';


can't remember - does native ios has the ...?

packages/flutter/lib/src/services/text_input.dart

packages/flutter/lib/src/widgets/editable_text.dart

hellohuanlin · 2023-08-17T17:44:18Z

packages/flutter/test/cupertino/text_field_test.dart

+    skip: isContextMenuProvidedByPlatform, // [intended] only applies to platforms where we supply the context menu.
+  );
+
+  testWidgets('Share shows up on iOS only (CupertinoTextField)', (WidgetTester tester) async {


does share show up in material for ios?

no (?), looks like cupertino to me

Regardless of whether TextField or CupertinoTextField is being used, the default context menu will reflect the current platform. So if you use TextField on an iPhone, you'll still get the iOS context menu.

So this test and the following test look correct as written to me. The only thing I would change is to move the TextField test below to material/text_field_test.dart.

justinmc

LGTM with nits 👍

packages/flutter/lib/src/services/text_input.dart

justinmc · 2023-08-17T20:39:19Z

packages/flutter/lib/src/widgets/editable_text.dart

  }

+  /// Launch the share interface for the current selection,
+  ///   as in the "Share" edit menu button on iOS.


Nit: Some weird indentation here after the ///.

justinmc · 2023-08-17T20:39:35Z

packages/flutter/lib/src/widgets/editable_text.dart

+  /// Launch the share interface for the current selection,
+  ///   as in the "Share" edit menu button on iOS.
+  ///
+  /// Currently this is only implemented for iOS.


Nit: Add an empty line of /// after this line.

justinmc · 2023-08-17T20:44:57Z

packages/flutter/test/cupertino/text_field_test.dart

+    skip: isContextMenuProvidedByPlatform, // [intended] only applies to platforms where we supply the context menu.
+  );
+
+  testWidgets('Share shows up on iOS only (CupertinoTextField)', (WidgetTester tester) async {


Regardless of whether TextField or CupertinoTextField is being used, the default context menu will reflect the current platform. So if you use TextField on an iPhone, you'll still get the iOS context menu.

So this test and the following test look correct as written to me. The only thing I would change is to move the TextField test below to material/text_field_test.dart.

justinmc · 2023-08-17T20:46:10Z

packages/flutter/test/cupertino/text_field_test.dart

+    skip: isContextMenuProvidedByPlatform, // [intended] only applies to platforms where we supply the context menu.
+  );
+
+  testWidgets('Share shows up on iOS only (TextField)', (WidgetTester tester) async {


As mentioned above, this test should be in material/text_field_test.dart.

justinmc · 2023-08-17T20:50:21Z

packages/flutter/test/widgets/selectable_text_test.dart

    await gesture.up();
    await tester.pump();
-    expect(find.byType(CupertinoButton), findsNWidgets(3));
+    expect(find.byType(CupertinoButton), findsNWidgets(4));


Nit: Seeing you change these numbers all over the place in these PRs makes me think we should have a better way to test this... expect(contextMenuButtonsShown(ContextMenuButtons.all)); or something like that.

That's probably beyond the scope of this PR, though. Also it might not be worth it if we don't add many more buttons. Just throwing out a thought.

… into material/text_field_test

auto-submit · 2023-08-17T21:25:48Z

auto label is removed for flutter/flutter/132599, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

…132599)

LouiseHsu added 2 commits August 15, 2023 15:24

initial PR

ff395de

Merge branch 'master' into add-share-to-selection-controls

2e532bd

LouiseHsu added 5 commits August 15, 2023 15:43

missing param

7e8a2de

missing param

53f7e8d

fix test

51554af

Merge branch 'master' into add-share-to-selection-controls

8d3aa50

add localizations

06ce804

github-actions bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Aug 16, 2023

LouiseHsu changed the title ~~initial PR~~ [Framework] Add Share to selection controls Aug 16, 2023

LouiseHsu marked this pull request as ready for review August 16, 2023 19:58

add missing localization test

f5a83d5

LouiseHsu requested review from hellohuanlin and justinmc August 17, 2023 17:33

hellohuanlin approved these changes Aug 17, 2023

View reviewed changes

LouiseHsu added 2 commits August 17, 2023 11:14

minor comment updates

69ac2e4

Merge branch 'master' into add-share-to-selection-controls

fe5ce71

justinmc approved these changes Aug 17, 2023

View reviewed changes

PR comments + move tests for textfield from cupertino/text_field_test…

4079846

… into material/text_field_test

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023

remove trailing space lol

4c67c2b

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 17, 2023

auto-submit bot merged commit 3f34b48 into flutter:master Aug 17, 2023

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 633b1ce402c7 (39 revisions) flutter/packages#4740

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

3f34b48 [Framework] Add Share to selection controls (flutter/flutter#…

a79afc4

…132599)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 312ef541156c (40 revisions) flutter/packages#4741

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

3f34b48 [Framework] Add Share to selection controls (flutter/flutter#…

19a8772

…132599)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to b52297da0620 (41 revisions) flutter/packages#4742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

3f34b48 [Framework] Add Share to selection controls (flutter/flutter#…

46ae130

…132599)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 5a556f8ecde6 (42 revisions) flutter/packages#4743

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

3f34b48 [Framework] Add Share to selection controls (flutter/flutter#…

972ca37

…132599)

HansMuller mentioned this pull request Aug 25, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

3f34b48 [Framework] Add Share to selection controls (flutter/flutter#…

26170b3

…132599)

ueman mentioned this pull request Nov 16, 2023

Share button in textfield menu crashes app on iPad #138550

Closed

2 tasks

bleroux mentioned this pull request Nov 22, 2023

[Android] Add 'Share' button to selection controls #138728

Closed

2 tasks

bleroux mentioned this pull request Jan 18, 2024

[iOS] Add default buttons to SelectionArea context menu #141775

Open

justinmc mentioned this pull request Jun 11, 2024

Support iOS 18 formatting menu #150068

Open

Conversation

LouiseHsu commented Aug 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

hellohuanlin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Aug 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LouiseHsu commented Aug 15, 2023 •

edited

Loading