[Windows] Allow overwriting the cache's Dart SDK archive license file#132669
Merged
auto-submit[bot] merged 12 commits intoflutter:masterfrom Aug 17, 2023
Merged
[Windows] Allow overwriting the cache's Dart SDK archive license file#132669auto-submit[bot] merged 12 commits intoflutter:masterfrom
auto-submit[bot] merged 12 commits intoflutter:masterfrom
Conversation
Contributor
|
would it be more resilient to future changes if we had a more general way of doing this rather than needing to know the exactly list of files we were expecting? |
packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/integration.shard/batch_entrypoint_test.dart
Outdated
Show resolved
Hide resolved
Member
Author
Summary of this Discord conversation: This fix is time sensitive as it unblocks the 3.14 beta release. A more robust solution is tracked by #132702. |
yaakovschectman
approved these changes
Aug 17, 2023
loic-sharma
added a commit
to loic-sharma/flutter
that referenced
this pull request
Aug 17, 2023
…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702
8 tasks
Contributor
|
This is introducing test failures for the windows, linux, and mac |
auto-submit bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
…nse file" (#132773) Reverts #132669 Introduced failure on `windows/mac/linux framework_library_tests`. ``` 05:41 +7318 ~22 -1: /b/s/w/ir/x/w/flutter/packages/flutter/test/material/menu_bar_theme_test.dart: (tearDownAll) [E] Expected: leak free Actual: <Instance of 'Leaks'> Which: contains leaks: # The text is generated by leak_tracker. # For leak troubleshooting tips open: # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md notDisposed: total: 3 objects: ValueNotifier<_OverlayEntryWidgetState?>: test: Constructor parameters override theme parameters identityHashCode: 407433615 FocusScopeNode: test: Constructor parameters override theme parameters identityHashCode: 513181650 FocusScopeNode: test: Constructor parameters override theme parameters identityHashCode: 704743556 package:matcher expect package:flutter_test/src/widget_tester.dart 458:18 expect package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 81:5 _tearDownTestingWithLeakTracking ===== asynchronous gap =========================== dart:async _CustomZone.registerBinaryCallback package:leak_tracker_flutter_testing/src/leak_tracking_flutter_testing.dart 59:9 configureLeakTrackingTearDown.<fn> ```
loic-sharma
added a commit
to loic-sharma/flutter
that referenced
this pull request
Aug 17, 2023
…flutter#132669) flutter/engine#43974 added a license file to the Dart SDK's ZIP archive. As a result, extracting the Dart SDK now needs to overwrite the cache's `LICENSE.dart_sdk_archive.md` file. This is a short-term solution that will be cherry-picked for the next [3.14 beta release](flutter#132267). Addresses flutter#132592. The long-term solution is tracked by flutter#132702
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/engine#43974 added a license file to the Dart SDK's ZIP archive which gets extracted to
flutter/bin/cache/LICENSE.dart_sdk_archive.md. As a result, extracting the Dart SDK now needs to update the cache'sLICENSE.dart_sdk_archive.mdfile.Windows ZIP extraction does not enable overwriting files. Thus, this change renames the cache's existing Dart SDK license file before extracting the Dart SDK archive.
This is a short-term solution that will be cherry-picked for the next 3.14 beta release. Addresses #132592.
The long-term solution is tracked by #132702
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.