Run new_gallery__transition_perf on Pixel 7 and Samsung A02#132772
Run new_gallery__transition_perf on Pixel 7 and Samsung A02#132772zanderso merged 1 commit intoflutter:masterfrom
Conversation
.ci.yaml
Outdated
There was a problem hiding this comment.
Wondering if this should be "cheetah"?
There was a problem hiding this comment.
it can be either (based on the values in the dimensions).
Pixel 7 Pro is more descriptive?
There was a problem hiding this comment.
Yeah, I'm hoping to keep "Pixel 7 Pro"
yusuf-goog
left a comment
There was a problem hiding this comment.
LGTM with one question
.ci.yaml
Outdated
There was a problem hiding this comment.
should this build be in this PR?
There was a problem hiding this comment.
I moved this existing build from another place in the file to be next to all the other new_gallery__transition_perf benchmarks.
9fa1b71 to
0a6fd00
Compare
| task_name: new_gallery_impeller__transition_perf | ||
|
|
||
| # Samsung A02, Impeller (OpenGL) | ||
| - name: Linux_samsung_a02 new_gallery_impeller__transition_perf |
There was a problem hiding this comment.
Just a heads up that we do not have any samsung a02 in the prod pool yet. What is the plan to add capacity in prod before enabling these tasks there? @yusuf-goog
There was a problem hiding this comment.
We are not enabling them in prod yet. Once zac is happy, i'll move some over to prod.
No description provided.