Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR by vashworth · Pull Request #132803 · flutter/flutter

vashworth · 2023-08-17T21:25:49Z

Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. xcodebuild error message recommend using TOOLCHAIN_DIR instead.

Since Xcode 15 isn't in CI, I tested it in a one-off led test:

Fixes #132755.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino · 2023-08-17T22:54:39Z

packages/flutter_tools/lib/src/migrations/cocoapods_toolchain_directory_migration.dart

+
+  @override
+  String? migrateLine(String line) {
+    if (line.startsWith('LD_RUNPATH_SEARCH_PATHS') || line.startsWith('LIBRARY_SEARCH_PATHS')) {


will this always be at the start of the line, or might there be leading whitespace? (IDK what format this file is in)

It's a Cocoapods-generated file, so it shouldn't have leading whitespace. I added a change to trim it out before comparison anyways, just in case/future-proofing

christopherfujino

One question about whether the pattern matching should allow leading whitespace, otherwise LGTM

…lutter#132803)

Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. `xcodebuild` error message recommend using TOOLCHAIN_DIR instead. Since Xcode 15 isn't in CI, I tested it in a one-off `led` test: * [Pre-fix failure](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/04e485a0b152a0720f5e561266f7a6e4fb64fc76227fcacc95b67486ae2771e7/+/build.proto) * [Post-fix success](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/d454a3e181e1a97692bdc1fcc197738fe04e4acf1cb20026fd040fd78513f3b0/+/build.proto) Fixes flutter#132755.

Original PR: #132803

lukaszciastko · 2023-09-20T15:02:28Z

I tried this fix, but I am still getting this error using latest Flutter beta and Xcode 15 in an existing project.

vashworth · 2023-09-20T15:09:52Z

I tried this fix, but I am still getting this error using latest Flutter beta and Xcode 15 in an existing project.

@lukaszciastko Could you please file a issue describing your error and include reproducible steps?

lukaszciastko · 2023-09-21T09:43:17Z

I tried this fix, but I am still getting this error using latest Flutter beta and Xcode 15 in an existing project.

@lukaszciastko Could you please file a issue describing your error and include reproducible steps?

The issue is exactly the same. Your fix doesn't work for my app, but it works when I create a new app. Having said that, none of the workarounds people are suggesting on the Internet have worked for me. I don't think I can include reproducible steps, because I don't know myself what causes it and an empty app works. I can see someone else mentioned here they are also having this issue with the latest Flutter: CocoaPods/CocoaPods#12012 (comment). I guess all I can do is keep investigating...

@vashworth

Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR` have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This broke CocoaPods support under Xcode 15, as reported in: CocoaPods/CocoaPods#12012 @vashworth worked around this in Flutter in: flutter#132803 The CocoaPods issue was resolved by the following PR to their repo: CocoaPods/CocoaPods#12009 and was released in CocoaPods 1.13.0. Also switches from an if-else chain to a switch for CocoaPodsStatus handling. Issue: flutter#133584 Related: flutter#132755

…lutter#132803)

@vashworth

Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR` have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This broke CocoaPods support under Xcode 15, as reported in: CocoaPods/CocoaPods#12012 @vashworth worked around this in Flutter in: #132803 The CocoaPods issue was resolved by the following PR to their repo: CocoaPods/CocoaPods#12009 and was released in CocoaPods 1.13.0. Also switches from an if-else chain to a switch for CocoaPodsStatus handling. Related: #133584 Related: #132755 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat Co-authored-by: Greg Spencer <[email protected]>

fix build failure due to DT_TOOLCHAIN_DIR

738f371

github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Aug 17, 2023

vashworth marked this pull request as ready for review August 17, 2023 22:40

vashworth requested a review from christopherfujino August 17, 2023 22:40

fix comment

7918bd0

christopherfujino reviewed Aug 17, 2023

View reviewed changes

christopherfujino approved these changes Aug 17, 2023

View reviewed changes

ignored leading whitespace when matching

a242f3e

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2023

auto-submit bot merged commit b52297d into flutter:master Aug 18, 2023

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to b52297da0620 (41 revisions) flutter/packages#4742

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

b52297d Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (flutter/f…

b0b5c72

…lutter#132803)

engine-flutter-autoroll mentioned this pull request Aug 18, 2023

Roll Flutter from 2502b51f86c1 to 5a556f8ecde6 (42 revisions) flutter/packages#4743

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2023

b52297d Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (flutter/f…

0da1b18

…lutter#132803)

vashworth mentioned this pull request Aug 21, 2023

[CP - 3.14] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR #132956

Merged

8 tasks

This was referenced Aug 21, 2023

[CP - 3.13] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR #132958

Merged

plugin_lint_mac test fails in CI with Xcode 15 #132980

Closed

auto-submit bot pushed a commit that referenced this pull request Aug 22, 2023

[CP - 3.13] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (#132958)

ce2fa57

Original PR: #132803

auto-submit bot pushed a commit that referenced this pull request Aug 28, 2023

[CP - 3.14] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (#132956)

8fb1eda

Original PR: #132803

vashworth mentioned this pull request Aug 29, 2023

[macOS Sonoma] Builds failing with error: DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS, use TOOLCHAIN_DIR instead #131527

Closed

This was referenced Sep 22, 2023

[MacOS 14.0 & Xcode15] "failed to write to a file" error during build #135199

Closed

[macOS,iOS] CocoaPods recommended version: 1.13.0 #135447

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

b52297d Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (flutter/f…

1753623

…lutter#132803)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR#132803

Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR#132803
auto-submit[bot] merged 3 commits intoflutter:masterfrom
vashworth:cocoapods_toolchain_directory_fix

vashworth commented Aug 17, 2023 •

edited

Loading

Uh oh!

christopherfujino Aug 17, 2023 •

edited

Loading

Uh oh!

vashworth Aug 18, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

lukaszciastko commented Sep 20, 2023 •

edited

Loading

Uh oh!

vashworth commented Sep 20, 2023

Uh oh!

lukaszciastko commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vashworth commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

christopherfujino Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vashworth Aug 18, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

lukaszciastko commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vashworth commented Sep 20, 2023

Uh oh!

lukaszciastko commented Sep 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Aug 17, 2023 •

edited

Loading

christopherfujino Aug 17, 2023 •

edited

Loading

lukaszciastko commented Sep 20, 2023 •

edited

Loading