Skip to content

[CP - 3.14] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR#132956

Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.14-candidate.0from
vashworth:cp_3.14_cocoapods_toolchain_dir_fix
Aug 28, 2023
Merged

[CP - 3.14] Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR#132956
auto-submit[bot] merged 1 commit intoflutter:flutter-3.14-candidate.0from
vashworth:cp_3.14_cocoapods_toolchain_dir_fix

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Aug 21, 2023 •
edited
Loading

Original PR: #132803

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth
Fix Xcode 15 build failure due to DT_TOOLCHAIN_DIR (flutter#132803)
ccc179b 
Starting in Xcode 15, when building macOS, DT_TOOLCHAIN_DIR cannot be used to evaluate LD_RUNPATH_SEARCH_PATHS or LIBRARY_SEARCH_PATHS. `xcodebuild` error message recommend using TOOLCHAIN_DIR instead.

Since Xcode 15 isn't in CI, I tested it in a one-off `led` test:
* [Pre-fix failure](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/04e485a0b152a0720f5e561266f7a6e4fb64fc76227fcacc95b67486ae2771e7/+/build.proto)
* [Post-fix success](https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/vashworth_google.com/d454a3e181e1a97692bdc1fcc197738fe04e4acf1cb20026fd040fd78513f3b0/+/build.proto)

Fixes flutter#132755.
@github-actions github-actions bot added tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Aug 21, 2023
@vashworth vashworth mentioned this pull request Aug 21, 2023
Closed
@vashworth vashworth marked this pull request as ready for review August 21, 2023 14:48
christopherfujino
christopherfujino approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 28, 2023
@auto-submit auto-submit bot merged commit 8fb1eda into flutter:flutter-3.14-candidate.0 Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vashworth @stuartmorgan-g @christopherfujino @godofredoc