Tooltip: Have preferBelow default to false instead of true#133007
Closed
chrisbobbe wants to merge 1 commit intoflutter:masterfrom
Closed
Tooltip: Have preferBelow default to false instead of true#133007chrisbobbe wants to merge 1 commit intoflutter:masterfrom
preferBelow default to false instead of true#133007chrisbobbe wants to merge 1 commit intoflutter:masterfrom
Conversation
Fixes flutter#133006. Also, update the dartdoc on `preferBelow` to mention the existing role of [TooltipThemeData.preferBelow].
github-actions
bot
added
framework
Contributor
|
We'll need a second review before landing this. |
Contributor
|
This is a sensible change but it's also a breaking change - the "Google Testing" failures are evidence of that. I think we'd be better off with an example that showed how to configure an app's TooltipTheme to do the right thing by default |
Contributor
Author
This was referenced Oct 2, 2023
chrisbobbe
added a commit
to chrisbobbe/flutter
that referenced
this pull request
Nov 2, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 3, 2023
As discussed at #133007 (comment), this is a docs change meant to help people in the absence of a fix for #133006, which is being closed as WONTFIX.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #133006.
Also, update the dartdoc on
preferBelowto mention the existing role of [TooltipThemeData.preferBelow].Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.