Closed
Conversation
Hixie
reviewed
Dec 2, 2017
| /// Content can slide under the [navigationBar] when they're translucent with | ||
| /// a [MediaQuery] padding hinting the top obstructed area. | ||
| /// a [MediaQuery] padding signaling the top obstructed area via | ||
| /// [MediaQueryData.padding]. |
Contributor
There was a problem hiding this comment.
I'm not sure I really understand what this paragraph is trying to say.
Hixie
reviewed
Dec 2, 2017
| final MediaQueryData existingMediaQuery = MediaQuery.of(context); | ||
|
|
||
| // TODO(https://github.com/flutter/flutter/issues/12912): | ||
| // TODO(xster): |
Contributor
There was a problem hiding this comment.
nit: you can remove the newline after the colon, too. that way grepping for "TODO" will show the message
Contributor
|
|
Member
Author
|
#13194 is reverted. I'm gonna close this and do this in the revert of the revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.