[framework] restore old zoom page transition for benchmarking.#133346
Merged
auto-submit[bot] merged 13 commits intoflutter:masterfrom Oct 10, 2023
Merged
[framework] restore old zoom page transition for benchmarking.#133346auto-submit[bot] merged 13 commits intoflutter:masterfrom
auto-submit[bot] merged 13 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
added 11 commits
August 26, 2023 11:46
Contributor
johnmccutchan
left a comment
johnmccutchan
left a comment
There was a problem hiding this comment.
Happy to see this!
| // that was too slow to run on the Skia backend. This is being benchmarked on | ||
| // the Impeller backend so that we can improve performance enough to restore | ||
| // the default behavior. | ||
| class _ZoomPageTransitionNoCache extends StatelessWidget { |
Contributor
There was a problem hiding this comment.
Is this class needed? Reading the code it looks like the existing class should work so long as you specify allowSnapshotting to be false?
Contributor
Author
There was a problem hiding this comment.
The old implementation uses an ImageFilter.matrix to scale the individual pages without causing text relayout/snapping. The fallback uses a transform layer because its designed to work well if we can't apply an ImageFilter to content, which is common with platform views on iOS/Web.
johnmccutchan
approved these changes
Oct 10, 2023
goderbauer
approved these changes
Oct 10, 2023
Comment on lines
+1060
to
+1061
|
|
||
|
|
Member
There was a problem hiding this comment.
nit: remove one of the extra blank lines?
Comment on lines
+1149
to
+1150
|
|
||
|
|
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 11, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past I switched the implementation of the zoom page transition because the performance of the old transition was terrible, but I'm hopeful that with Impeller we'll be able to identify and fix the issues that made it so slow. In order to evaluate this though, we need to be able to opt into the old transition for benchmarks on CI.
#129742
#121325