Make drawer demo header not scroll away#13337
Merged
xster merged 2 commits intoflutter:masterfrom Dec 5, 2017
Merged
Conversation
Hixie
reviewed
Dec 4, 2017
| }; | ||
| rootObject = 97C146E61CF9000F007C117D /* Project object */; | ||
| } No newline at end of file | ||
| } |
Member
Author
There was a problem hiding this comment.
Xcode just auto-adds final newlines
Contributor
There was a problem hiding this comment.
I didn't mean the newline, I meant all the changes to this file. They seem unrelated to the patch.
Member
Author
There was a problem hiding this comment.
Oh I see. Ya, it's somewhat unrelated. Leftovers from #13195 which added new plugins. We'll just get these diffs if anyone flutter runs on iOS until we check them in.
Contributor
|
test? |
Member
Author
|
Added test and fixed account header overflow text. Had to refactor a bit. |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Make drawer demo header not scroll * Add test for gallery drawer demo and fix user accounts drawer header overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13335
Also update gallery xcode project with new plugin dependencies