Improve doctor output on incomplete Visual Studio installation by loic-sharma · Pull Request #133390 · flutter/flutter

loic-sharma · 2023-08-26T20:40:57Z

Flutter doctor warns if the user is updating Visual Studio or has paused a Visual Studio update. The current output recommends reinstalling Visual Studio. This is unnecessary as the user should be able to use the Visual Studio Installer app to complete the installation:

This message is covered by this existing test:

flutter/packages/flutter_tools/test/general.shard/windows/visual_studio_validator_test.dart

Lines 68 to 81 in 229b74d

    
           testWithoutContext('Emits a partial status when Visual Studio installation is incomplete', () async { 
        
             final VisualStudioValidator validator = VisualStudioValidator( 
        
               userMessages: userMessages, 
        
               visualStudio: fakeVisualStudio, 
        
             ); 
        
             configureMockVisualStudioAsInstalled(); 
        
             fakeVisualStudio.isComplete = false; 
        
             final ValidationResult result = await validator.validate(); 
        
             final ValidationMessage expectedMessage = ValidationMessage.error(userMessages.visualStudioIsIncomplete); 
        
             expect(result.messages.contains(expectedMessage), true); 
        
             expect(result.type, ValidationType.partial); 
        
           });

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

andrewkolos

LGTM

christopherfujino · 2023-08-28T18:12:44Z

Ahh, I see now the context of your question. In this case, I would say copy pasting the relevant error message to your test, and either renaming the existing test or creating a new one with a name that makes it clear this is an expectation will help document this behavior and prevent regression from clueless tool maintainers :)

loic-sharma · 2023-08-28T18:35:14Z

I updated the tests, please take another look @andrewkolos @christopherfujino. Thanks!

andrewkolos

LGTM

christopherfujino

LGTM

christopherfujino · 2023-08-28T19:50:16Z

The customer_testing failure is actively being worked on upstream. See discord #tree-status for more context.

christopherfujino · 2023-08-29T18:24:28Z

Filed b/298053054 and manually overrode Google testing

loic-sharma · 2023-08-29T20:45:18Z

@christopherfujino Thanks! Looks like Google testing is now hitting a second issue, filed b/298076936

christopherfujino · 2023-08-30T16:39:30Z

:'(

flutter/flutter#133390)

Improve doctor output on incomplete Visual Studio installation

ade8d9c

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 26, 2023

loic-sharma marked this pull request as ready for review August 28, 2023 17:22

loic-sharma requested review from andrewkolos and christopherfujino August 28, 2023 17:22

andrewkolos approved these changes Aug 28, 2023

View reviewed changes

Update tests

291bf2f

github-actions bot added the a: desktop Running on desktop label Aug 28, 2023

loic-sharma requested a review from andrewkolos August 28, 2023 18:34

andrewkolos approved these changes Aug 28, 2023

View reviewed changes

christopherfujino approved these changes Aug 28, 2023

View reviewed changes

Merge branch 'master' into vs_installation_paused

7b8708b

Jasguerrero self-assigned this Aug 31, 2023

Jasguerrero merged commit b4753c3 into flutter:master Aug 31, 2023

loic-sharma deleted the vs_installation_paused branch August 31, 2023 23:27

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to eb77b525c2d7 (40 revisions) flutter/packages#4828

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

407ce14

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 0f3bd90d9b10 (42 revisions) flutter/packages#4829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

d37ed01

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 78ff1226c9f9 (43 revisions) flutter/packages#4830

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

fd99517

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 37c55bab2cea (45 revisions) flutter/packages#4831

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

9fa43b9

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 033274c66a0d (46 revisions) flutter/packages#4832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

b33a1f4

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 3, 2023

Roll Flutter from c175cf87a6a3 to 96621ebf0fd5 (60 revisions) flutter/packages#4839

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

2031b43

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 3, 2023

Roll Flutter from c175cf87a6a3 to ef9befc9da9f (61 revisions) flutter/packages#4840

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

b3e3c74

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 4, 2023

Roll Flutter from c175cf87a6a3 to ef9befc9da9f (61 revisions) flutter/packages#4843

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

8359da6

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 4, 2023

Roll Flutter from c175cf87a6a3 to ef9befc9da9f (61 revisions) flutter/packages#4844

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

8ecbb8a

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 5, 2023

Roll Flutter from c175cf87a6a3 to 6eca007a81ad (62 revisions) flutter/packages#4848

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

35141dd

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 5, 2023

Roll Flutter from c175cf87a6a3 to cb0a613ec695 (64 revisions) flutter/packages#4850

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

00ab648

flutter/flutter#133390)

engine-flutter-autoroll mentioned this pull request Sep 5, 2023

Roll Flutter from c175cf87a6a3 to 225106323315 (65 revisions) flutter/packages#4853

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

995491e

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

7e4c031

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

d02b85b

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

76691ed

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

1191b96

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

16fd045

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

e96a6ee

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

e945faf

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

c706381

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

0f6bd93

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

8206292

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

f40e251

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

8640846

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

06437ac

flutter/flutter#133390)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

b4753c3 Improve doctor output on incomplete Visual Studio installation (

e0e4cd1

flutter/flutter#133390)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve doctor output on incomplete Visual Studio installation#133390

Improve doctor output on incomplete Visual Studio installation#133390
Jasguerrero merged 3 commits intoflutter:masterfrom
loic-sharma:vs_installation_paused

loic-sharma commented Aug 26, 2023 •

edited

Loading

Uh oh!

andrewkolos left a comment

Uh oh!

christopherfujino commented Aug 28, 2023

Uh oh!

loic-sharma commented Aug 28, 2023

Uh oh!

andrewkolos left a comment

Uh oh!

christopherfujino left a comment

Uh oh!

christopherfujino commented Aug 28, 2023

Uh oh!

christopherfujino commented Aug 29, 2023

Uh oh!

loic-sharma commented Aug 29, 2023

Uh oh!

christopherfujino commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	testWithoutContext('Emits a partial status when Visual Studio installation is incomplete', () async {
	final VisualStudioValidator validator = VisualStudioValidator(
	userMessages: userMessages,
	visualStudio: fakeVisualStudio,
	);
	configureMockVisualStudioAsInstalled();
	fakeVisualStudio.isComplete = false;

	final ValidationResult result = await validator.validate();
	final ValidationMessage expectedMessage = ValidationMessage.error(userMessages.visualStudioIsIncomplete);

	expect(result.messages.contains(expectedMessage), true);
	expect(result.type, ValidationType.partial);
	});

Conversation

loic-sharma commented Aug 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Aug 28, 2023

Uh oh!

loic-sharma commented Aug 28, 2023

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

christopherfujino commented Aug 28, 2023

Uh oh!

christopherfujino commented Aug 29, 2023

Uh oh!

loic-sharma commented Aug 29, 2023

Uh oh!

christopherfujino commented Aug 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

loic-sharma commented Aug 26, 2023 •

edited

Loading