Cover some test/widgets tests with leak tracking by ksokolovskyi · Pull Request #133767 · flutter/flutter

ksokolovskyi · 2023-08-31T15:21:00Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Tests

Updates absorb_pointer_test.dart to use testWidgetsWithLeakTracking;
Updates actions_test.dart to use testWidgetsWithLeakTracking;
Updates align_test.dart to use testWidgetsWithLeakTracking;
Updates animated_align_test.dart to use testWidgetsWithLeakTracking;
Updates animated_container_test.dart to use testWidgetsWithLeakTracking;
Updates animated_cross_fade_test.dart to use testWidgetsWithLeakTracking;
Updates animated_grid_test.dart to use testWidgetsWithLeakTracking;
Updates animated_image_filtered_repaint_test.dart to use testWidgetsWithLeakTracking;
Updates animated_list_test.dart to use testWidgetsWithLeakTracking;
Updates animated_opacity_repaint_test.dart to use testWidgetsWithLeakTracking;
Updates animated_padding_test.dart to use testWidgetsWithLeakTracking;
Updates animated_positioned_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-08-31T15:25:42Z

@polina-c, could you please take a look at this PR?

polina-c

Thank you!!!

This reverts commit be06151.

Reverts #133767 Causing failures to Mac framework_tests_widgets and Linux framework_tests_widgets

vashworth · 2023-08-31T17:07:57Z

@ksokolovskyi @polina-c I reverted this PR (#133779) due to failures in the tree. Here's some examples:

https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20framework_tests_widgets/12951/overview
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_widgets/12833/overview

ksokolovskyi · 2023-08-31T17:38:48Z

@vashworth, thank you for the revert. My bad.
@polina-c, sorry, I will fix the test and create a new PR.

polina-c · 2023-08-31T17:53:11Z

@vashworth, thank you for the revert. My bad. @polina-c, sorry, I will fix the test and create a new PR.

It is ok, as probability of test flakiness little increases when we deal with memory leaks. Thank you for taking care of it.

polina-c · 2023-08-31T18:04:47Z

@vashworth , is it possible to get full list of failures?

vashworth · 2023-08-31T18:09:17Z

@vashworth , is it possible to get full list of failures?

I'm pretty sure it's just those 2 tests I linked above that were failing. Linux framework_tests_widgets and Mac framework_tests_widgets.

It's possible it could have caused more failures, but it hasn't finished testing all tests. You can view what tests failed on https://flutter-dashboard.appspot.com/#/build

ksokolovskyi · 2023-08-31T18:10:32Z

@polina-c As I understand, the problem is in test:

flutter/packages/flutter/test/widgets/animated_list_test.dart

Line 630 in 82ded60

final ScrollController controller = ScrollController();

We now have ScrollController instrumentation which caused the error.

01:12 +2156 ~75 -1: /Volumes/Work/s/w/ir/x/w/flutter/packages/flutter/test/widgets/animated_list_test.dart: (tearDownAll) [E]                                                                          
  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
            notDisposed:
              total: 1
              objects:
                ScrollController:
                  test: AnimatedList.shrinkwrap is forwarded to its inner CustomScrollView
                  identityHashCode: 291972861

vashworth · 2023-08-31T18:11:17Z

Here's how to filter the dashboard to see just the commit that failed https://flutter-dashboard.appspot.com/#/build?hashFilter=792e26df9540cf2cf510ea0c11a53ba10a243424&repo=flutter&branch=master

…tter#133767)

Test cover some test/widgets tests with leak tracking

e60fcec

github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 31, 2023

polina-c mentioned this pull request Aug 31, 2023

Clean up notDisposed leaks in Flutter Framework, phase 1. dart-lang/leak_tracker#134

Closed

polina-c approved these changes Aug 31, 2023

View reviewed changes

polina-c merged commit be06151 into flutter:master Aug 31, 2023

vashworth added a commit that referenced this pull request Aug 31, 2023

Revert "Cover some test/widgets tests with leak tracking (#133767)"

7dc996c

This reverts commit be06151.

vashworth mentioned this pull request Aug 31, 2023

Revert "Cover some test/widgets tests with leak tracking" #133779

Merged

auto-submit bot pushed a commit that referenced this pull request Aug 31, 2023

Revert "Cover some test/widgets tests with leak tracking" (#133779)

c57e4e7

Reverts #133767 Causing failures to Mac framework_tests_widgets and Linux framework_tests_widgets

ksokolovskyi mentioned this pull request Aug 31, 2023

Cover some test/widgets tests with leak tracking #133803

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to eb77b525c2d7 (40 revisions) flutter/packages#4828

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

95dbc72

…tter#133767)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 0f3bd90d9b10 (42 revisions) flutter/packages#4829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

38fef78

…tter#133767)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 78ff1226c9f9 (43 revisions) flutter/packages#4830

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

3d81d07

…tter#133767)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 37c55bab2cea (45 revisions) flutter/packages#4831

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

3d44752

…tter#133767)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 033274c66a0d (46 revisions) flutter/packages#4832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

e8a69ad

…tter#133767)

engine-flutter-autoroll mentioned this pull request Sep 1, 2023

Roll Flutter from c175cf87a6a3 to 8cbf42a7d9f5 (47 revisions) flutter/packages#4833

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

377ab7a

…tter#133767)

HansMuller mentioned this pull request Sep 1, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

d2a3531

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

4847c3a

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

1276ce5

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

6c612f6

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

66b7567

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

3855cb9

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

49b3784

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

ea83841

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

e2f3840

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

b683acb

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

e57cd00

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

b3ae49f

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

81fabca

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

52936f8

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

af8404b

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

28afedb

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

580593c

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

3aa4194

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

35145c6

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

89e0ca8

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

0eb7258

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

f269571

…tter#133767)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

fec9971

…tter#133767)

ksokolovskyi mentioned this pull request Sep 10, 2023

Cover more test/widgets tests with leak tracking #2 #134387

Merged

8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

be06151 Cover some test/widgets tests with leak tracking (flutter/flu…

18afcad

…tter#133767)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cover some test/widgets tests with leak tracking#133767

Cover some test/widgets tests with leak tracking#133767
polina-c merged 1 commit intoflutter:masterfrom
ksokolovskyi:leak-tracking-tests

ksokolovskyi commented Aug 31, 2023

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

polina-c left a comment

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

polina-c commented Aug 31, 2023 •

edited

Loading

Uh oh!

polina-c commented Aug 31, 2023

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ksokolovskyi commented Aug 31, 2023

Description

Tests

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

polina-c commented Aug 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

polina-c commented Aug 31, 2023

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

ksokolovskyi commented Aug 31, 2023

Uh oh!

vashworth commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

polina-c commented Aug 31, 2023 •

edited

Loading