Skip to content

Reland leak fix for EditableTextState [prod-leak-fix]#133806

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Renzo-Olivares:leak-fix-fix
Sep 3, 2023
Merged

Reland leak fix for EditableTextState [prod-leak-fix]#133806
auto-submit[bot] merged 3 commits intoflutter:masterfrom
Renzo-Olivares:leak-fix-fix

Conversation

@Renzo-Olivares
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares commented Aug 31, 2023

Relands: #131377
Reverted in: #133804

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 31, 2023
@Renzo-Olivares Renzo-Olivares changed the title Re-land leak fix for EditableTextState Reland leak fix for EditableTextState Aug 31, 2023
@polina-c polina-c mentioned this pull request Sep 3, 2023
Closed
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2023
@auto-submit auto-submit bot merged commit ef9befc into flutter:master Sep 3, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
1b06c62
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
daa0d4e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
c19c67a
Renzo-Olivares added a commit that referenced this pull request Sep 4, 2023
@Renzo-Olivares
Revert "Reland leak fix for EditableTextState (#133806)"
af2be84 
This reverts commit ef9befc.
@Renzo-Olivares Renzo-Olivares mentioned this pull request Sep 4, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
f64534f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
8528e32
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
b6d35a6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
27e1e45
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
bf39913
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
1bfc92c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
11fef84
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
4c49738
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
bb19873
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
3fbeb6d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
e567b60
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
633e105
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
ec2a0db
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
c537828
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
caa95b7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
3fc518a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
80d0872
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
ef9befc Reland leak fix for EditableTextState (flutter/flutter#133806)
39267b0
@polina-c polina-c changed the title Reland leak fix for EditableTextState Reland leak fix for EditableTextState [prod-leak-fix] Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @polina-c