Skip to content

Run Mac_arm64_ios run_debug_test_macos in presubmit#133869

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
vashworth:run_debug_test_macos_in_presubmit_v2
Sep 1, 2023
Merged

Run Mac_arm64_ios run_debug_test_macos in presubmit#133869
auto-submit[bot] merged 1 commit intoflutter:masterfrom
vashworth:run_debug_test_macos_in_presubmit_v2

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Sep 1, 2023 •
edited
Loading

Reland #133788.

Fixes #118830.
Fixes #125342.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@vashworth
Copy link
Contributor Author

vashworth commented Sep 1, 2023

Confirmed it ran on flutter-devicelab-mac-38 and passed: https://ci.chromium.org/ui/p/flutter/builders/try/Mac_arm64_ios%20run_debug_test_macos/345/overview

@vashworth vashworth requested a review from yusuf-goog September 1, 2023 15:38
@vashworth vashworth mentioned this pull request Sep 1, 2023
Closed
yusuf-goog
yusuf-goog reviewed Sep 1, 2023
View reviewed changes
@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit auto-submit bot merged commit 37c55ba into flutter:master Sep 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
40ae4a8 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
ff04d28 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
85b683f 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
e8ad25e 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
3cebe97 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
531bbc2 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
2214342 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
839e050 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
62d8c79 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
40498a3 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
e9c8738 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
f639317 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
d9a2d1e 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
9e9b390 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
3134df7 
…flutter#133869)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
07be2a6 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
f6a0ceb 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
494429a 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
86062bc 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
4f560e7 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
afcb8c4 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
bebedd7 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
d8fad15 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
187083c 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
1c32818 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
8402d23 
…flutter#133869)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
37c55ba Run Mac_arm64_ios run_debug_test_macos in presubmit (flutter/…
a2d9444 
…flutter#133869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@yusuf-goog yusuf-goog yusuf-goog approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

2 participants

@vashworth @yusuf-goog