Add ios analyzer command for universal links#134155
Add ios analyzer command for universal links#134155auto-submit[bot] merged 2 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
the
tool
There was a problem hiding this comment.
would we ever want to grab the data from both ios and android subprojects at the same time?
There was a problem hiding this comment.
The dashboard would grab both data to display a comprehensive view.
but I imagine there will be case we only want the date for a certain platform.
There was a problem hiding this comment.
So this long string is messing up verbose help formatting (the android --build-variant help also does this, I must not have checked for that PR). Can you make valueHelp shorter, and then move these instructions to the help field? Something like:
valueHelp: '<configuration>',
There was a problem hiding this comment.
common.dart is our test utility library that re-exports what we need from package:test
| import 'package:test/test.dart'; | |
| import '../../src/common.dart'; |
There was a problem hiding this comment.
| test('can output json file', () async { | |
| testWithoutContext('can output json file', () async { |
There was a problem hiding this comment.
| test('can list build options', () async { | |
| testWithoutContext('can list build options', () async { |
packages/flutter_tools/test/commands.shard/hermetic/ios_analyze_test.dart
Outdated
Show resolved
Hide resolved
packages/flutter_tools/test/commands.shard/hermetic/ios_analyze_test.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
i think we should test that we're writing the write data to this file.
There was a problem hiding this comment.
The writing data part is mocked in this test, and the actual functionality is tested in the IosProject.outputUniversalLinkSettings unit test
There was a problem hiding this comment.
This test in this pr is just making sure the analyze end up calling IosProject.outputUniversalLinkSettings with the right parameters
There was a problem hiding this comment.
sorry for the delay, I will finish reviewing before EOD today (Thursday)
chunhtai
force-pushed
the
ios-analyze
branch
from
9be05c6 to
b58ceac
Compare
chunhtai
added
the
autosubmit
|
Oh wow, overriding github status is finally working now. Sorry I override the google testing to pass for this pr, was using this pr to test a fix we have been working on. Definitely let me know if you need an actual Google Testing test to run. |
flutter/flutter@da676f7...7c28e8e 2023-09-09 [email protected] Roll Flutter Engine from 4e3231af6efc to d1913cb6a276 (1 revision) (flutter/flutter#134355) 2023-09-09 [email protected] Roll Flutter Engine from 348e3a376807 to 4e3231af6efc (1 revision) (flutter/flutter#134353) 2023-09-09 [email protected] Day picker should dispose created MaterialStatesController's. (flutter/flutter#133884) 2023-09-09 [email protected] Roll Flutter Engine from 00ef109b845e to 348e3a376807 (1 revision) (flutter/flutter#134349) 2023-09-09 [email protected] Roll Flutter Engine from 7af8a5d8d556 to 00ef109b845e (1 revision) (flutter/flutter#134336) 2023-09-09 [email protected] Roll Flutter Engine from 1f2da3d69da7 to 7af8a5d8d556 (2 revisions) (flutter/flutter#134332) 2023-09-09 [email protected] Roll Flutter Engine from 3a5f3ad1d054 to 1f2da3d69da7 (1 revision) (flutter/flutter#134328) 2023-09-09 [email protected] Roll Flutter Engine from d6aa2d9061c1 to 3a5f3ad1d054 (3 revisions) (flutter/flutter#134327) 2023-09-09 [email protected] Roll Flutter Engine from 66bec85d5005 to d6aa2d9061c1 (1 revision) (flutter/flutter#134324) 2023-09-08 [email protected] Roll Flutter Engine from 8d2892211366 to 66bec85d5005 (3 revisions) (flutter/flutter#134321) 2023-09-08 [email protected] Roll Flutter Engine from 2da727e23518 to 8d2892211366 (1 revision) (flutter/flutter#134316) 2023-09-08 [email protected] Fix memory leak in _DraggableScrollableSheetState (flutter/flutter#134212) 2023-09-08 [email protected] RestorationManager should dispatch creation in constructor. (flutter/flutter#133911) 2023-09-08 [email protected] Remove TextPainter migration flag from the framework (flutter/flutter#134274) 2023-09-08 [email protected] InputDecoration.error should activate error state (flutter/flutter#134001) 2023-09-08 [email protected] Roll Flutter Engine from b2cb1d271a88 to 2da727e23518 (1 revision) (flutter/flutter#134314) 2023-09-08 [email protected] Update chip docs to clarify how to specify a shape with no border & explain default values for Material 3 (flutter/flutter#134298) 2023-09-08 [email protected] Add ios analyzer command for universal links (flutter/flutter#134155) 2023-09-08 [email protected] Roll Flutter Engine from 47a79306eed3 to b2cb1d271a88 (5 revisions) (flutter/flutter#134313) 2023-09-08 [email protected] Roll Flutter Engine from 6d6b44886175 to 47a79306eed3 (2 revisions) (flutter/flutter#134310) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 participants
ios version of https://github.com/flutter/flutter/pull/131009/files
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.