Remove dangling MediaQuery paddings for non-fullscreen dialogs#13436
Closed
xster wants to merge 1 commit intoflutter:masterfrom
Closed
Remove dangling MediaQuery paddings for non-fullscreen dialogs#13436xster wants to merge 1 commit intoflutter:masterfrom
xster wants to merge 1 commit intoflutter:masterfrom
Conversation
…val of mediaquery paddings for non fullscreen ones
Member
Author
|
Actually I changed my mind. Moved solution to #13438 instead for customizable padding removal per side depending on where the popup is positioned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13408
A bit over-generalized but it was a bit strange too that the concept of fullscreen routes weren't explicit.
Added a fullscreen flag and automatically remove paddings for non-fullscreen routes' inner contents.