Cover more test/widgets tests with leak tracking #2 by ksokolovskyi · Pull Request #134387 · flutter/flutter

ksokolovskyi · 2023-09-10T17:11:44Z

Description

This PR changes testWidgets by testWidgetsWithLeakTracking in number of flutter/test/widgets tests according to the dart-lang/leak_tracker#134.

Marks leaks

Memory Leak: RenderEditable does not dispose LeaderLayer when testing with _TestRecordingCanvasMatcher #134386

Tests

Updates draggable_test.dart to use testWidgetsWithLeakTracking;
Updates drawer_test.dart to use testWidgetsWithLeakTracking;
Updates dual_transition_builder_test.dart to use testWidgetsWithLeakTracking;
Updates editable_text_cursor_test.dart to use testWidgetsWithLeakTracking;
Updates editable_text_shortcuts_test.dart to use testWidgetsWithLeakTracking;
Updates editable_text_show_on_screen_test.dart to use testWidgetsWithLeakTracking;
Updates editable_text_test.dart to use testWidgetsWithLeakTracking;
Updates ensure_visible_test.dart to use testWidgetsWithLeakTracking;
Updates error_widget_builder_test.dart to use testWidgetsWithLeakTracking;
Updates fade_in_image_test.dart to use testWidgetsWithLeakTracking;
Updates fade_transition_test.dart to use testWidgetsWithLeakTracking;
Updates fitted_box_test.dart to use testWidgetsWithLeakTracking;
Updates flex_test.dart to use testWidgetsWithLeakTracking;
Updates flow_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

ksokolovskyi · 2023-09-10T17:12:45Z

cc @polina-c

packages/flutter/test/widgets/editable_text_cursor_test.dart

polina-c

Thanks. Couple comments.

packages/flutter/test/widgets/editable_text_show_on_screen_test.dart

packages/flutter/test/widgets/editable_text_test.dart

polina-c

Couple more comments.

ksokolovskyi · 2023-09-10T19:11:23Z

@polina-c I live in the CET timezone, so I will continue to work on this PR tomorrow (Monday).

packages/flutter/test/widgets/editable_text_test.dart

polina-c · 2023-09-11T21:29:51Z

@ksokolovskyi , is it ready for next round of review?

ksokolovskyi · 2023-09-12T05:46:19Z

@polina-c yes, could you please take a look again?

packages/flutter/test/widgets/editable_text_show_on_screen_test.dart

ksokolovskyi · 2023-09-12T19:11:59Z

@polina-c thanks a lot for your attentiveness!

polina-c

LGTM

auto-submit · 2023-09-12T22:00:01Z

auto label is removed for flutter/flutter/134387, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

chunhtai

LGTM

auto-submit · 2023-09-12T23:23:02Z

auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2023-09-12T23:34:58Z

auto label is removed for flutter/flutter/134387, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

…tter#134387)

Updated some test/widgets tests

c62e923

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Sep 10, 2023

ksokolovskyi mentioned this pull request Sep 10, 2023

Memory Leak: RenderEditable does not dispose LeaderLayer when testing with _TestRecordingCanvasMatcher #134386

Closed

2 tasks

polina-c reviewed Sep 10, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_cursor_test.dart Outdated Show resolved Hide resolved

Add username in todos

b4dd3de

polina-c reviewed Sep 10, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_cursor_test.dart Show resolved Hide resolved

polina-c requested changes Sep 10, 2023

View reviewed changes

Update editable_text_cursor_test.dart

fd86191

polina-c reviewed Sep 10, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_show_on_screen_test.dart Outdated Show resolved Hide resolved

polina-c reviewed Sep 10, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_test.dart Show resolved Hide resolved

polina-c requested changes Sep 10, 2023

View reviewed changes

ksokolovskyi added 2 commits September 10, 2023 20:29

Revert one test

bed4438

Fix

da3a275

polina-c mentioned this pull request Sep 11, 2023

Clean up notDisposed leaks in Flutter Framework, phase 1. dart-lang/leak_tracker#134

Closed

ksokolovskyi added 3 commits September 11, 2023 13:41

Revert some tests

0466286

Fix tests

75c8bc8

Add more tests

ee45427

ksokolovskyi requested a review from polina-c September 11, 2023 15:22

polina-c reviewed Sep 11, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_test.dart Outdated Show resolved Hide resolved

ksokolovskyi and others added 3 commits September 11, 2023 20:48

Fix edited tests

876114d

Merge branch 'master' into leak-tracking-tests-2

52000c5

Merge branch 'master' into leak-tracking-tests-2

301becf

Merge branch 'master' into leak-tracking-tests-2

2eb8981

ksokolovskyi requested a review from polina-c September 12, 2023 05:46

polina-c reviewed Sep 12, 2023

View reviewed changes

packages/flutter/test/widgets/editable_text_show_on_screen_test.dart Outdated Show resolved Hide resolved

ksokolovskyi requested a review from polina-c September 12, 2023 20:15

polina-c approved these changes Sep 12, 2023

View reviewed changes

polina-c requested a review from chunhtai September 12, 2023 21:56

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

chunhtai approved these changes Sep 12, 2023

View reviewed changes

chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

Merge branch 'master' into leak-tracking-tests-2

5fe2c43

polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 12, 2023

polina-c merged commit 7d0c9b7 into flutter:master Sep 13, 2023

engine-flutter-autoroll mentioned this pull request Sep 13, 2023

Roll Flutter from 4e7a07af882c to 622c2b2b0721 (24 revisions) flutter/packages#4914

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

d6abc11

…tter#134387)

ksokolovskyi changed the title ~~Cover more test/widgets tests with leak tracking~~ Cover more test/widgets tests with leak tracking #2 Sep 13, 2023

engine-flutter-autoroll mentioned this pull request Sep 13, 2023

Roll Flutter from 4e7a07af882c to 0aa879919cb2 (25 revisions) flutter/packages#4915

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

8866854

…tter#134387)

engine-flutter-autoroll mentioned this pull request Sep 13, 2023

Roll Flutter from 4e7a07af882c to f38dcb122905 (27 revisions) flutter/packages#4916

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

3fb3cac

…tter#134387)

engine-flutter-autoroll mentioned this pull request Sep 13, 2023

Roll Flutter from 4e7a07af882c to 7cd8b4074fa4 (28 revisions) flutter/packages#4917

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

88866be

…tter#134387)

engine-flutter-autoroll mentioned this pull request Sep 13, 2023

Roll Flutter from 4e7a07af882c to 61b890bfcbc1 (29 revisions) flutter/packages#4918

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

99f0b86

…tter#134387)

HansMuller mentioned this pull request Sep 15, 2023

Flutter Framework Team: Notable Commits #121415

Closed

Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023

Cover more test/widgets tests with leak tracking (flutter#134387)

a0f6593

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

7d0c9b7 Cover more test/widgets tests with leak tracking (flutter/flu…

1ae2f66

…tter#134387)

Conversation

ksokolovskyi commented Sep 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Marks leaks

Tests

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Sep 10, 2023

Uh oh!

Uh oh!

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Sep 10, 2023

Uh oh!

Uh oh!

polina-c commented Sep 11, 2023

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

Uh oh!

ksokolovskyi commented Sep 12, 2023

Uh oh!

polina-c left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 12, 2023

Uh oh!

chunhtai left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Sep 12, 2023

Uh oh!

auto-submit bot commented Sep 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ksokolovskyi commented Sep 10, 2023 •

edited

Loading