Let translucent Cupertino bars have its scaffold children automatically pad their heights - second try#13440
Merged
xster merged 3 commits intoflutter:masterfrom Dec 8, 2017
Merged
Conversation
…ly pad their heights (flutter#13194) * Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds. * tests * const lint * Rename base abstract class to generalized ObstructingPreferredSizeWidget
Hixie
reviewed
Dec 11, 2017
| childCount: 50, | ||
| new SliverPadding( | ||
| // Top media query padding already consumed by CupertinoSliverNavigationBar. | ||
| padding: MediaQuery.of(context).removePadding(removeTop: true).padding, |
Contributor
There was a problem hiding this comment.
this doesn't seem right... we're consuming the padding, but we're not actually updating the MediaQuery for the children.
Contributor
There was a problem hiding this comment.
oh, i see, this is the demo file, not a widget. probably ok then.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
…ly pad their heights - second try (flutter#13440) * Let translucent Cupertino bars have its scaffold children automatically pad their heights (flutter#13194) * Let lists automatically add sliver padding from media query. Translucent nav and tab bars leave behind media query paddings in scaffolds. * tests * const lint * Rename base abstract class to generalized ObstructingPreferredSizeWidget * review * More docs and comments from flutter#13317
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12913
Basically a revert of #13317 that also integrates comments from #13310
Remove manual padding to account for obstructed area
Obstructed areas are signaled to scaffold children via MediaQuery
List/GridViews automatically consume and sliver pad MediaQuery in main axis direction
Causes of the original revert should be now solved by #13337 and #13438