Enable private field promotion for framework#134473
Enable private field promotion for framework#134473auto-submit[bot] merged 1 commit intoflutter:masterfrom
Conversation
There was a problem hiding this comment.
The web compiler is unhappy about the removal of ! here and below:
/b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/dart --disable-dart-dev /b/s/w/ir/x/w/flutter/bin/cache/dart-sdk/bin/snapshots/frontend_server.dart.snapshot --sdk-root /b/s/w/ir/x/w/flutter/bin/cache/flutter_web_sdk/ --incremental --target=dartdevc --experimental-emit-debug-metadata -DDART_HHH_BOT=false -DFLUTTER_WEB_AUTO_DETECT=false -DFLUTTER_WEB_USE_SKIA=true --output-dill /b/s/w/ir/x/t/flutter_tools.VOZITK/flutter_test.PPUCHG/out --packages /b/s/w/ir/x/w/flutter/packages/flutter/.dart_tool/package_config.json -Ddart.vm.profile=false -Ddart.vm.product=false --enable-asserts --track-widget-creation --filesystem-root /b/s/w/ir/x/w/flutter/packages/flutter/test --filesystem-root /b/s/w/ir/x/t/flutter_tools.VOZITK/flutter_test.PPUCHG/ --filesystem-scheme org-dartlang-app --initialize-from-dill build/a2632b1a2d119a1f9ce340959afb28ff.cache.dill.track.dill --platform file:///b/s/w/ir/x/w/flutter/bin/cache/flutter_web_sdk/kernel/ddc_outline_sound.dill --verbosity=error --sound-null-safety
[ +16 ms] <- compile org-dartlang-app:///main.dart
[+11509 ms] lib/src/rendering/error.dart:160:20: Error: Method 'layout' cannot be called on 'Paragraph?' because it is potentially null.
[ +2 ms] - 'Paragraph' is from 'dart:ui'.
[ ] Try calling using ?. instead.
[ ] _paragraph.layout(ui.ParagraphConstraints(width: width));
[ ] ^^^^^^
[ +6 ms] lib/src/rendering/error.dart:161:52: Error: Property 'height' cannot be accessed on 'Paragraph?' because it is potentially null.
[ ] - 'Paragraph' is from 'dart:ui'.
[ ] Try accessing using ?. instead.
[ ] if (size.height > padding.top + _paragraph.height + padding.bottom) {
[ ] ^^^^^^
[ ] lib/src/rendering/error.dart:61:28: Context: '_paragraph' refers to a property so it couldn't be promoted.
[ ] See http://dart.dev/go/non-promo-property
[ ] late final ui.Paragraph? _paragraph;
[ ] ^
[ +1 ms] lib/src/rendering/error.dart:164:38: Error: The argument type 'Paragraph?' can't be assigned to the parameter type 'Paragraph' because 'Paragraph?' is nullable and 'Paragraph' isn't.
[ ] - 'Paragraph' is from 'dart:ui'.
[ ] context.canvas.drawParagraph(_paragraph, offset + Offset(left, top));
There was a problem hiding this comment.
The ! should be removable because of if (_paragraph != null) in line 152, though. This issue also only surfaces on the web. When running in the VM, the removal of the ! is not causing any trouble. Presumably, there is a bug somewhere in the web compilation pipeline?
@stereotype441 Any idea what may be going on here? If necessary, I can try to boil this down to a smaller repro case.
There was a problem hiding this comment.
We likely have to wait for dart-lang/sdk@1da590f to roll into Flutter, which is expected to fix this problem.
47a5d86 to
4a65a06
Compare
|
auto label is removed for flutter/flutter/134473, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
4a65a06 to
6a3e15e
Compare
|
auto label is removed for flutter/flutter/134473, due to - The status or check suite Linux web_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
flutter/flutter@b7d0e8c...8936504 2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998) 2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983) 2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978) 2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953) 2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954) 2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123) 2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473) 2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884) 2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805) 2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869) 2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542) 2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955) 2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938) 2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956) 2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2. Part of flutter#134476.

New feature in upcoming Dart 3.2. See dart-lang/language#2020. Feature is enabled by bumping the min SDK version to 3.2.
Part of #134476.