Skip to content

[1p cp] revert split display list#134491

Merged
XilaiZhang merged 1 commit intoflutter:flutter-3.14-candidate.13from
XilaiZhang:flutter-3.14-candidate.13
Sep 12, 2023
Merged

[1p cp] revert split display list#134491
XilaiZhang merged 1 commit intoflutter:flutter-3.14-candidate.13from
XilaiZhang:flutter-3.14-candidate.13

Conversation

@XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Sep 12, 2023 •
edited
Loading

roll flutter/engine#45678 into framework

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 12, 2023

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Sep 12, 2023
@Jasguerrero
Copy link
Contributor

Jasguerrero commented Sep 12, 2023

Should we wait for the cut off date?

@XilaiZhang
Copy link
Contributor Author

XilaiZhang commented Sep 12, 2023

Should we wait for the cut off date?

Umm like when this branch is promoted to the new beta?

@Jasguerrero
Copy link
Contributor

Jasguerrero commented Sep 12, 2023 •
edited
Loading

Should we wait for the cut off date?

Umm like when this branch is promoted to the new beta?

I thought this was from this week release, but I see that it's a 1p cp now nvm

Jasguerrero
Jasguerrero approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Jasguerrero Jasguerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang
Copy link
Contributor Author

XilaiZhang commented Sep 12, 2023

umm this one is 3.14.- 13. I am also trying to roll engine into 3.14-14 in #134495

umm just to clarify, what would be the concern?

@XilaiZhang XilaiZhang merged commit 1677740 into flutter:flutter-3.14-candidate.13 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

@itsjustkevin itsjustkevin Awaiting requested review from itsjustkevin

+1 more reviewer

@Jasguerrero Jasguerrero Jasguerrero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XilaiZhang @Jasguerrero @fluttergithubbot