Roll Flutter Engine from 496ef6a9c277 to 4519acd50345 (8 revisions)#134583
Closed
engine-flutter-autoroll wants to merge 8 commits intoflutter:masterfrom
Conversation
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Sep 12, 2023
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Contributor
Author
|
AutoRoller is stopped; closing the active roll. |
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Sep 12, 2023
) Reverts #42672 This is causing breakages in the Framework roller on golden tests: flutter/flutter#134583
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-60b6267b-20e8-49f5-8730-ef0e4db0007d-1694553682
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter/engine@496ef6a...4519acd
2023-09-12 [email protected] Roll Skia from 211d63b1e1f5 to 2d295711337c (7 revisions) (flutter/engine#45729)
2023-09-12 [email protected] Use a single OffscreenCanvas for rendering in CanvasKit (flutter/engine#42672)
2023-09-12 [email protected] Manual roll Dart SDK from 43d4b1373788 to 1ee7ef8bbc65 (6 revisions) (flutter/engine#45726)
2023-09-12 [email protected] Reland "Build iOS unittest target in unopt builds" (#44356)"" (#45346)" (flutter/engine#45519)
2023-09-12 [email protected] Roll Skia from a4f8f5177c8b to 211d63b1e1f5 (2 revisions) (flutter/engine#45724)
2023-09-12 [email protected] Fix JS interop signatures to use only JS types. (flutter/engine#45668)
2023-09-12 [email protected] [ios] Fix testDeallocated failing locally. (flutter/engine#45663)
2023-09-12 [email protected] [iOS] move arm64 builds to arm machines (flutter/engine#45721)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md