Skip to content

Marks Windows_android channels_integration_test_win to be flaky#134637

Merged
zanderso merged 1 commit intoflutter:masterfrom
fluttergithubbot:Xo9jANHnSA
Sep 13, 2023
Merged

Marks Windows_android channels_integration_test_win to be flaky#134637
zanderso merged 1 commit intoflutter:masterfrom
fluttergithubbot:Xo9jANHnSA

Conversation

@fluttergithubbot
Copy link
Contributor

@fluttergithubbot fluttergithubbot commented Sep 13, 2023

Issue link: #134636

@fluttergithubbot fluttergithubbot added the team-engine Owned by Engine team label Sep 13, 2023
@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Sep 13, 2023
@zanderso zanderso added team-framework Owned by Framework team and removed team-engine Owned by Engine team labels Sep 13, 2023
@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 13, 2023

auto label is removed for flutter/flutter/134637, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

keyonghan
keyonghan approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 13, 2023

auto label is removed for flutter/flutter/134637, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso
Copy link
Member

zanderso commented Sep 13, 2023

Why is Google testing failing?

@keyonghan keyonghan mentioned this pull request Sep 13, 2023
Closed
@keyonghan
Copy link
Contributor

keyonghan commented Sep 13, 2023

Created #134668 to investigate.

@zanderso zanderso merged commit 639c092 into flutter:master Sep 13, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
639c092 Marks Windows_android channels_integration_test_win to be fla…
be21e91 
…ky (flutter/flutter#134637)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
639c092 Marks Windows_android channels_integration_test_win to be fla…
047a1f5 
…ky (flutter/flutter#134637)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 13, 2023
@engine-flutter-autoroll
639c092 Marks Windows_android channels_integration_test_win to be fla…
06a5492 
…ky (flutter/flutter#134637)
@XilaiZhang
Copy link
Contributor

XilaiZhang commented Sep 13, 2023

There seems to be two separate issues:

  1. .ci.yaml should be excluded in the roller script. when I looked at the filters for framework in roller script, it does not seem to exlude .ci.yaml. However, on flutter repo in google3 it seems like .ci.yaml files are excluded. Maybe @chingjun or @CaseyHillers would know more on how .ci.yaml files are excluded from roller script? thank you!

  2. Instructions on how to resolve merge conflict isn't clear. sent cl/565087659 for review

Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@fluttergithubbot @Mairramer
Marks Windows_android channels_integration_test_win to be flaky (flut…
a9e44e6 
…ter#134637)

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Windows_android channels_integration_test_win"
}
-->
Issue link: flutter#134636
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
639c092 Marks Windows_android channels_integration_test_win to be fla…
32e170f 
…ky (flutter/flutter#134637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

+1 more reviewer

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. team-framework Owned by Framework team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fluttergithubbot @zanderso @keyonghan @XilaiZhang