Skip to content

Remove extra padding if a dropdown menu entry also has a leading icon#135004

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
QuncCccccc:dropdown_menu_leading_icon_layout
Sep 22, 2023
Merged

Remove extra padding if a dropdown menu entry also has a leading icon#135004
auto-submit[bot] merged 3 commits intoflutter:masterfrom
QuncCccccc:dropdown_menu_leading_icon_layout

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Sep 19, 2023

Fixes #131350

This PR is to remove the extra padding in DropdownMenuEntry if both the text field and the dropdown menu entry have leading icons.

After fix:
Screenshot 2023-09-19 at 4 35 24 PM

Before fix:
Screenshot 2023-09-19 at 4 37 58 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 19, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review September 19, 2023 10:39
@HansMuller HansMuller force-pushed the dropdown_menu_leading_icon_layout branch from 1b4bda3 to 5d5832a Compare September 21, 2023 19:40
HansMuller
HansMuller approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 22, 2023
@auto-submit auto-submit bot merged commit 09f7d7c into flutter:master Sep 22, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
3c122a0 
…ing icon (flutter/flutter#135004)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
60ed01c 
…ing icon (flutter/flutter#135004)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
d6310dd 
…ing icon (flutter/flutter#135004)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
8967912 
…ing icon (flutter/flutter#135004)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
51cf09f 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
b4b4bd2 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
4c6ddae 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
0b0cad9 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
cd70f8e 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
580c6df 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
50586a0 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
5f29035 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
311ceeb 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
95f5cd0 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
774dca4 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
471fb33 
…ing icon (flutter/flutter#135004)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
fa817b9 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
c822734 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
96369a1 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
2a41e35 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
f576f0a 
…ing icon (flutter/flutter#135004)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
36097b7 
…ing icon (flutter/flutter#135004)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@QuncCccccc @Mairramer
Remove extra padding if a dropdown menu entry also has a leading icon (…
1eefcc9 
…flutter#135004)

Fixes flutter#131350

This PR is to remove the extra padding in `DropdownMenuEntry` if both the text field and the dropdown menu entry have leading icons.

**After** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 35 24 PM" src="proxy.php?url=https://github.com/flutter/flutter/assets/36861262/ed7d92a5-3f96-4106-a03e-09258ea3709f">

**Before** fix:
<img width="300" alt="Screenshot 2023-09-19 at 4 37 58 PM" src="proxy.php?url=https://github.com/flutter/flutter/assets/36861262/fdbfef54-6c93-48fb-bd64-41fa31dde531">
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
09f7d7c Remove extra padding if a dropdown menu entry also has a lead…
42b3844 
…ing icon (flutter/flutter#135004)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DropdownMenu leading icon usage layout issue

2 participants

@QuncCccccc @HansMuller