Add --frontend-server-starter-path option to flutter run and flutter test#135038
Merged
derekxu16 merged 2 commits intoflutter:masterfrom Sep 21, 2023
Merged
Add --frontend-server-starter-path option to flutter run and flutter test#135038derekxu16 merged 2 commits intoflutter:masterfrom
--frontend-server-starter-path option to flutter run and flutter test#135038derekxu16 merged 2 commits intoflutter:masterfrom
Conversation
9c5ae44 to
bf1e3c1
Compare
bf1e3c1 to
79a4e64
Compare
| argParser.addOption( | ||
| FlutterOptions.kFrontendServerStarterPath, | ||
| help: 'When this value is provided, the frontend server will be started ' | ||
| 'in JIT mode from the specified file, instead of from the AOT ' |
Contributor
There was a problem hiding this comment.
Does this need to be a dart source entrypoint, a JIT snapshot, or either?
Contributor
Author
There was a problem hiding this comment.
I was only considering the case of it being a Dart source entrypoint, but you're right that the AppJIT snapshot case is also supported. I've updated the help message.
--frontend-server-starter-path option to flutter run and flutter test
christopherfujino
approved these changes
Sep 21, 2023
Contributor
christopherfujino
left a comment
There was a problem hiding this comment.
LGTM (verified this worked for me locally on linux)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 21, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 22, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 25, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 27, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 28, 2023
…and `flutter test` (flutter/flutter#135038)
Mairramer
pushed a commit
to Mairramer/flutter
that referenced
this pull request
Oct 10, 2023
13 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…and `flutter test` (flutter/flutter#135038)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.